Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Toml module #39

Closed
wants to merge 1 commit into from
Closed

Fix Toml module #39

wants to merge 1 commit into from

Conversation

alaa
Copy link

@alaa alaa commented May 15, 2017

No description provided.

@phromo
Copy link
Contributor

phromo commented May 19, 2017

+1. rationale: influxdb-cookbook switched to the 'toml' gem, saying in their PR that chef 13 depends on inspec which depends on the toml gem.

See bdangit/chef-influxdb#143

@phromo
Copy link
Contributor

phromo commented May 19, 2017

tho, I guess the PR should be fixed so that it does not regress ['telegraf']['rubysource'] and works with a config-only recipe. ping if you want me to fix it for you alaa.

@fishnix
Copy link
Contributor

fishnix commented May 30, 2017

That toml gem issue has been a problem in the past. It looks like you guys are working on this, ping me once it's complete and the conflicts are resolved so I can review. Thanks for the PR!

@codylewandowski
Copy link
Contributor

Is there any idea when this PR will be ready to go? As of today, we're now unable to use this cookbook based on the issues outlined in #41. This PR would theoretically resolve those issues.

@fishnix
Copy link
Contributor

fishnix commented Jun 14, 2017

@codylewandowski @phromo @alaa I'm happy to merge this up once it gets fixed (or also happy to merge a new PR and close this one if that's easier).

@codylewandowski
Copy link
Contributor

@fishnix Thanks! I should be able to open a new PR relatively quickly.

@fishnix
Copy link
Contributor

fishnix commented Jun 14, 2017

closing this out in favor of #43. Thanks!

@fishnix fishnix closed this Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants