ENT-12511: Fixed bug where cf-net.exe get fails to create file
#231
Conversation
|
There was an error running your pipeline, see logs for details. |
|
There was an error running your pipeline, see logs for details. |
|
There was an error running your pipeline, see logs for details. |
|
There was an error running your pipeline, see logs for details. |
|
There was an error running your pipeline, see logs for details. |
|
@cf-bottom jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/11553/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11553/ |
|
Here we go |
|
There was an error running your pipeline, see logs for details. |
|
@cf-bottom Jenkins please :) |
larsewi
force-pushed
the
atomic
branch
2 times, most recently
from
142fbab to
0fc2ba7
Compare
|
There was an error running your pipeline, see logs for details. |
When calling `fdopen()` in `safe_fopen_create_perms()` using the `"wx"` mode we get... ``` warning: Invalid parameter passed to C runtime function. ``` ...on Windows. Looking in both Linux man pages and Win32 API, I see that the mode argument `"x"` is not specified as a valid argument in either of them. Hence, it is probably not supported. Maybe Unix systems simply ignore it, while Windows returns error? Either way, I believe it is safe to omit it, given that we already called `open()` with the `O_EXCL` flag, and that we are getting the file stream from that same file descriptor. Ticket: ENT-12511 Changelog: Title Signed-off-by: Lars Erik Wik <[email protected]>
|
There was an error running your pipeline, see logs for details. |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/11556/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11556/ |
|
|
When calling
fdopen()insafe_fopen_create_perms()using the"wx"mode we get...
...on Windows. Looking in both Linux man pages and Win32 API, I see that
the mode argument
"x"is not specified as a valid argument in eitherof them. Hence, it is probably not supported. Maybe Unix systems simply
ignore it, while Windows returns error? Either way, I believe it is safe
to omit it, given that we already called
open()with theO_EXCLflag, and that we are getting the file stream from that same file
descriptor.
Ticket: ENT-12511
Changelog: Title
Signed-off-by: Lars Erik Wik [email protected]