plugins/utility/harpoon: added harpoon #672
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harpoon (branch harpoon2) has been added as a plugin. Set under navigation to allow for more naviation plugins to be added in the future (set telescope under navigation?). Basic options and keybinds are included.
NotAShelf
requested changes
Feb 28, 2025
Formatting and changelog
NotAShelf
reviewed
Mar 1, 2025
|
Left one quick comment, LGTM otherwise. |
NotAShelf
requested changes
Mar 4, 2025
Comment on lines
+26
to
+27
| Any time the ui menu is closed then we will save the | ||
| state back to the backing list, not to the fs |
There was a problem hiding this comment.
Suggested change
| Any time the ui menu is closed then we will save the | |
| state back to the backing list, not to the fs | |
| Any time the ui menu is closed then we will save the | |
| state back to the backing list, not to the fs |
Comment on lines
+34
to
+35
| Any time the ui menu is closed then the state of the | ||
| list will be sync'd back to the fs |
There was a problem hiding this comment.
Suggested change
| Any time the ui menu is closed then the state of the | |
| list will be sync'd back to the fs | |
| Any time the ui menu is closed then the state of the | |
| list will be sync'd back to the fs |
Comment on lines
+46
to
+47
| How the out list key is looked up. This can be useful | ||
| when using worktrees and using git remote instead of file path |
There was a problem hiding this comment.
Suggested change
| How the out list key is looked up. This can be useful | |
| when using worktrees and using git remote instead of file path | |
| How the out list key is looked up. This can be useful | |
| when using worktrees and using git remote instead of file path |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Harpoon (branch harpoon2) has been added as a plugin. Set under navigation to allow for more navigation plugins to be added in the future (set telescope under navigation?).
Basic options and keybinds are included.
First nvf and nix contribution, followed the guidelines as well as I could but tips and improvements appreciated :)
Closes #612