fix: type error on signPayload()

fix: update tests
Notarise-gov-sg · Oct 11, 2021 · 214f29a · 214f29a
1 parent b8428a2
commit 214f29a
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 14 deletions.
diff --git a/fixtures/notarise-examples/pdt-multi-record.json b/fixtures/notarise-examples/pdt-multi-record.json
@@ -14,7 +14,7 @@
         "barcode": {
           "alternateText": "Scan this QR to verify your HealthCert",
           "type": "qrCode",
-          "value": "https://www.verify.gov.sg/"
+          "value": "https://www.verify.gov.sg"
         },
         "expiration": "2021-10-01",
         "logo": {

diff --git a/fixtures/notarise-examples/pdt-single-record.json b/fixtures/notarise-examples/pdt-single-record.json
@@ -14,7 +14,7 @@
         "barcode": {
           "alternateText": "Scan this QR to verify your HealthCert",
           "type": "qrCode",
-          "value": "https://www.verify.gov.sg/"
+          "value": "https://www.verify.gov.sg"
         },
         "expiration": "2021-10-01",
         "logo": {

diff --git a/fixtures/notarise-examples/vac-multi-record.json b/fixtures/notarise-examples/vac-multi-record.json
@@ -10,11 +10,11 @@
         "id": "3388000000016843803.some_uuid",
         "issuerId": "3388000000016843803",
         "cardColorHex": "#FFFFFF",
-        "title": "COVID-19 Test Result Card",
+        "title": "Vaccination Certificate",
         "barcode": {
           "alternateText": "Scan this QR to verify your HealthCert",
           "type": "qrCode",
-          "value": "https://www.verify.gov.sg/"
+          "value": "https://www.verify.gov.sg"
         },
         "expiration": "2021-10-01",
         "logo": {

diff --git a/fixtures/notarise-examples/vac-single-record.json b/fixtures/notarise-examples/vac-single-record.json
@@ -10,11 +10,11 @@
         "id": "3388000000016843803.some_uuid",
         "issuerId": "3388000000016843803",
         "cardColorHex": "#FFFFFF",
-        "title": "COVID-19 Test Result Card",
+        "title": "Vaccination Certificate",
         "barcode": {
           "alternateText": "Scan this QR to verify your HealthCert",
           "type": "qrCode",
-          "value": "https://www.verify.gov.sg/"
+          "value": "https://www.verify.gov.sg"
         },
         "expiration": "2021-10-01",
         "logo": {

diff --git a/src/index.ts b/src/index.ts
@@ -18,8 +18,8 @@ export default (secret: Secret) => {
      * @param payload
      * @returns
      */
-    signPayload: (payload: string | Record<string, unknown> | Buffer) =>
-      jwt.sign(payload, secret, { algorithm: "RS256" }),
+    // eslint-disable-next-line @typescript-eslint/ban-types
+    signPayload: (payload: string | object | Buffer) => jwt.sign(payload, secret, { algorithm: "RS256" }),
 
     /**
      * Returns the full URL with the provided signedPayload.

diff --git a/src/models/gpay-covid-card.test.ts b/src/models/gpay-covid-card.test.ts
@@ -18,16 +18,21 @@ export const patientDetails: PatientDetails = {
   patientName: "Tan Chen Chen",
 };
 
-export const basicDetails: BasicDetails = {
+export const basicDetailsTest: BasicDetails = {
   iss: "[email protected]",
   uuid: "some_uuid",
   issuerId: "3388000000016843803",
   title: "COVID-19 Test Result Card",
-  qr: "https://www.verify.gov.sg/",
+  qr: "https://www.verify.gov.sg",
   expiration: "2021-10-01",
   patientDetails: genPatientDetails(patientDetails),
 };
 
+export const basicDetailsVaccination: BasicDetails = {
+  ...basicDetailsTest,
+  title: "Vaccination Certificate",
+};
+
 export const testingRecord: TestingRecord = {
   administrationDateTime: "27 September 2020, 2:15 pm SGT",
   contactInfo: "MacRitchie Hospital, Thomson Road, Singapore 123000",
@@ -53,27 +58,29 @@ export const vaccinationRecord: VaccinationRecord = {
 
 describe("genGPayCovidCard() [Single record]", () => {
   it("TestingRecord", () => {
-    const singleTestingRecord = genGPayCovidCard(basicDetails, [genTestingRecord(testingRecord)]);
+    const singleTestingRecord = genGPayCovidCard(basicDetailsTest, [genTestingRecord(testingRecord)]);
     expect({ iat: TEST_IAT, ...singleTestingRecord }).toStrictEqual(notarisePdtSingleRecord);
   });
 
   it("VaccinationRecord", () => {
-    const singleVaccinationRecord = genGPayCovidCard(basicDetails, [genVaccinationRecord(vaccinationRecord)]);
+    const singleVaccinationRecord = genGPayCovidCard(basicDetailsVaccination, [
+      genVaccinationRecord(vaccinationRecord),
+    ]);
     expect({ iat: TEST_IAT, ...singleVaccinationRecord }).toStrictEqual(notariseVacSingleRecord);
   });
 });
 
 describe("genGPayCovidCard() [Multi record]", () => {
   it("TestingRecord", () => {
-    const multiTestingRecord = genGPayCovidCard(basicDetails, [
+    const multiTestingRecord = genGPayCovidCard(basicDetailsTest, [
       genTestingRecord(testingRecord),
       genTestingRecord(testingRecord),
     ]);
     expect({ iat: TEST_IAT, ...multiTestingRecord }).toStrictEqual(notarisePdtMultiRecord);
   });
 
   it("VaccinationRecord", () => {
-    const multiVaccinationRecord = genGPayCovidCard(basicDetails, [
+    const multiVaccinationRecord = genGPayCovidCard(basicDetailsVaccination, [
       genVaccinationRecord(vaccinationRecord),
       genVaccinationRecord(vaccinationRecord),
     ]);