drivers: gpio: npcm: fix wrong setting when setup gpio open drain mode

fix wrong setting when setup gpio open drain mode. only output open drain mode with pull-up setting need enable DEVALTCX bit. Signed-off-by: James Chiang <[email protected]>
Nuvoton-Israel · Sep 20, 2024 · 2d38214 · 2d38214
1 parent d844585
commit 2d38214
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/drivers/gpio/gpio_npcm.c b/drivers/gpio/gpio_npcm.c
@@ -137,13 +137,14 @@ static int gpio_npcm_config(const struct device *dev,
 	else
 		inst->PTYPE &= ~mask;
 
-	/* Select opend drain with pull up need enable GPIO_PULL_EN */
-	if (((flags & GPIO_OPEN_DRAIN) != 0) &&
-	    ((flags & GPIO_PULL_UP) != 0)) {
-		inst_scfg->DEVALTCX |= BIT(NPCM_DEVALTCX_GPIO_PULL_EN);
+	/* Open drain output mode want to enable internal pull up */
+	if ((flags & GPIO_OPEN_DRAIN) && (flags & GPIO_OUTPUT)) {
+		if ((flags & GPIO_PULL_UP)) {
+			inst_scfg->DEVALTCX |= BIT(NPCM_DEVALTCX_GPIO_PULL_EN);
+		}
 	}
 
-	/* Select pull-up/down of GPIO 0:pull-up 1:pull-down */
+	/* Enable and select pull-up/down of GPIO 0:pull-up 1:pull-down */
 	if ((flags & GPIO_PULL_UP) != 0) {
 		inst->PPUD  &= ~mask;
 		inst->PPULL |= mask;