Updated project to use ember-modifier to simplify api #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 6, 2021 14:09
Added ember-cli-typescript for typescript support. Updated various addon dependencies using ember-cli-update. Updated split.js to the lastest version. Fixed failing test. Fixed deprecation message for not specifying capabilities of the modifier(ember-modifier does it automatically now)
|
@bekzod Is there anything that needs to be done for this merge request to be accepted? |
|
Sorry, I don't have merge privilages |
|
@bekzod Ok, do you know who has merge privileges? I would really like to get this pull request merged. |
|
@mattmarcum You were the last person to merge a pull request. Can you look over this and check if it ready to be merged? |
|
@dbingham do you have merge privilages still? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ember-cli-typescript for typescript support to the project.
Updated various addon dependencies using ember-cli-update.
Updated split.js to the lastest version.
Fixed failing test and added new tests.
Fixed deprecation message for not specifying capabilities of the modifier(ember-modifier does it automatically now).