Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving implicit connections (3.0.4 port of #3856) #3906

Merged
merged 10 commits into from
Jun 17, 2024
Merged

Resolving implicit connections (3.0.4 port of #3856) #3906

merged 10 commits into from
Jun 17, 2024

Commits on Jun 13, 2024

  1. Clarify resolving implicit connections (3.0.4) 

    This clarifies how to handle resolving implicit (non-URI-based)
connections in multi-document OpenAPI Descriptions.

While the behavior is implementation-defined overall, this
RECOMMENDS a single approach based on how things behaved going
back to the 2.0 referencing model.  This allows Security Schemes
and Tags to (like the top-level Server Objects) define
a deployment-specific interface for referenced documents to access.

This entry document interface approach makes less sense for the
Discriminator Object, but it can use the URI syntax of `mapping`
to keep things within the local document.

This also aligns the search for matching `operationId`s with
3.1's full-document parsing requirements.

Note that the term "complete OpenAPI document" has been defined
in another change pending approval on the 3.0.4 branch.
    @handrews
    handrews committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    bdbabd4 View commit details
    Browse the repository at this point in the history

  2. wording review feedback 

    Co-authored-by: Ralf Handl <[email protected]>
    @handrews @ralfhandl
    handrews and ralfhandl committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    44f08ec View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Jeremy Fiel <[email protected]>
    @handrews @jeremyfiel
    handrews and jeremyfiel committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    c302993 View commit details
    Browse the repository at this point in the history

  4. More review feedback.

    @handrews
    handrews committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    8de6836 View commit details
    Browse the repository at this point in the history

  5. Add example resolution of Security Requirement

    @handrews
    handrews committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    e11a7cc View commit details
    Browse the repository at this point in the history

  6. Fix stray random characters (review feedback) 

    Co-authored-by: Ralf Handl <[email protected]>
    @handrews @ralfhandl
    handrews and ralfhandl committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    ae35691 View commit details
    Browse the repository at this point in the history

  7. example as YAML/JSON via HTTP negotiation

    @handrews
    handrews committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    c8a154f View commit details
    Browse the repository at this point in the history

  8. Formatting fix (review feedback) 

    Co-authored-by: Ralf Handl <[email protected]>
    @handrews @ralfhandl
    handrews and ralfhandl committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    80ec461 View commit details
    Browse the repository at this point in the history

  9. Apply suggestions from code review 

    Co-authored-by: Jeremy Fiel <[email protected]>
    @handrews @jeremyfiel
    handrews and jeremyfiel committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    1639c5d View commit details
    Browse the repository at this point in the history

  10. 3.0 uses URLs not URIs in refs

    @handrews
    handrews committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    7dd7719 View commit details
    Browse the repository at this point in the history