-
-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] account_invoice_section_sale_order: Migration to 18.0 #1832
Open
LucasTran380381
wants to merge
22
commits into
OCA:18.0
Choose a base branch
from
LucasTran380381:18.0-mig-account_invoice_section_sale_order
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[18.0][MIG] account_invoice_section_sale_order: Migration to 18.0 #1832
LucasTran380381
wants to merge
22
commits into
OCA:18.0
from
LucasTran380381:18.0-mig-account_invoice_section_sale_order
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description from the readme : When invoicing multiple sale orders at the same time, sale orders may be grouped by customer into a single invoice. Unfortunately when this happens, it is hard to know which invoice line belongs to which sale order. This module helps by grouping invoicing lines into sections with the name of the targeted sale order. This is only done when an invoice targets multiple sale order.
The function signature as changed in v14
[UPD] Update account_invoice_section_sale_order.pot [UPD] README.rst
Translated using Weblate (Spanish) Currently translated at 100.0% (1 of 1 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_section_sale_order Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_section_sale_order/es/
Currently translated at 100.0% (1 of 1 strings) Translation: account-invoicing-17.0/account-invoicing-17.0-account_invoice_section_sale_order Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-17-0/account-invoicing-17-0-account_invoice_section_sale_order/it/
Refactor preparation of sections Refactor to allow different section grouping Add field to allow different possibilities of grouping invoice lines from sale order
…on tests In OCA repo, now we have this error: Traceback (most recent call last): File "/__w/account-invoicing/account-invoicing/account_invoice_section_sale_order/tests/test_invoice_group_by_sale_order.py", line 109, in test_create_invoice self.assertEqual(line.name, result[line.sequence][0]) KeyError: 1
Currently translated at 100.0% (18 of 18 strings) Translation: account-invoicing-17.0/account-invoicing-17.0-account_invoice_section_sale_order Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-17-0/account-invoicing-17-0-account_invoice_section_sale_order/it/
13 tasks
TDu
approved these changes
Nov 26, 2024
ajaniszewska-dev
approved these changes
Nov 28, 2024
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in v18:
account_move_line
name
now include product names. This PR updates test cases to reflect this change. odoo/odoo@b647d20#diff-78f3e1847de8ca0acf28d72a412947a549acdb08142d1dadf7646363d7972cb0R518.