Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][IMP] account_invoice_show_currency_line_rate: add journal item rate and consider journal item balance for credit amounts #1838

Open
wants to merge 2 commits into
base: 13.0
Choose a base branch
from
Open

[13.0][IMP] account_invoice_show_currency_line_rate: add journal item rate and consider journal item balance for credit amounts #1838

wants to merge 2 commits into from

Conversation

JordiMForgeFlow
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow commented Nov 11, 2024 •
edited
Loading

  • Add currency rate field on journal items
  • Compute rate based on the balance instead of looking just at the debit amount

@JordiMForgeFlow JordiMForgeFlow force-pushed the 13.0-imp-account_invoice_show_currency-line_rate branch from b577198 to 31c878b Compare November 11, 2024 09:30
@JordiMForgeFlow JordiMForgeFlow force-pushed the 13.0-imp-account_invoice_show_currency-line_rate branch from 31c878b to b7197f6 Compare November 11, 2024 09:52
@JordiMForgeFlow
Copy link
Contributor Author

@victoralmau could you check these changes? :)

@AaronHForgeFlow
Copy link
Contributor

Is the new field because the currency rate in the lines can be different from the currency rate of the journal entries? is that because of manual editions of the amount currency?

@JordiMForgeFlow
Copy link
Contributor Author

@AaronHForgeFlow you can create misc entries with lines having different currency. Odoo already provides this field from >=V16

AaronHForgeFlow
AaronHForgeFlow approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

JoanSForgeFlow
JoanSForgeFlow approved these changes Nov 14, 2024
View reviewed changes
Copy link

@JoanSForgeFlow JoanSForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@JoanSForgeFlow JoanSForgeFlow mentioned this pull request Nov 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanSForgeFlow JoanSForgeFlow JoanSForgeFlow approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JordiMForgeFlow @AaronHForgeFlow @OCA-git-bot @JoanSForgeFlow