-
-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] [16.0] account_invoice_clearing #1858
base: 16.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 👍🏼
/ocabot merge patch
What a great day to merge this nice PR. Let's do it! |
@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1858-by-rafaelbn-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
@legalsylvain can you check failure of tests on your module when this module is merging? https://github.com/OCA/account-invoicing/actions/runs/12286819756/job/34287688237#step:8:189 |
@Shide which module ? |
Sorry. I didn't implemented the "secondary currency" part (and never worked on multi currency). Better if another maintainer takes a look on that topic. regards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have discovered 2 errors:
- In a multi-company environment, the wizard seems to show invoices from the 2 companies.
- When sorting by due date, a traceback appears.
Video: https://www.loom.com/share/506fdbdd16e54983989d6136ac40a2a6?sid=54162518-11de-450b-86ed-6abc9b4d87a1
…ault max date when sorting
MT-3067 @moduon @fcvalgar @rafaelbn @yajo @Gelojr please review if you want :)