Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] [16.0] account_invoice_clearing #1858

Open
wants to merge 6 commits into
base: 16.0
Choose a base branch
from

Conversation

Shide
Copy link
Contributor

@Shide Shide commented Dec 4, 2024

  • Changing related account type fields and renamed those functions.
  • Dropping Add button and Remove button because reset button does the same.
  • Reworked a little bit the UI because groups works in a different way.
  • Removed readonly fields related to analytic (just was info).
  • Hide sequence column when someone starts to add amounts to clear (causes a crash).
  • Fixed tests
  • Make protected some functions that are not called via UI

MT-3067 @moduon @fcvalgar @rafaelbn @yajo @Gelojr please review if you want :)

Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

@rafaelbn rafaelbn added this to the 16.0 milestone Dec 11, 2024
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍🏼

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1858-by-rafaelbn-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 11, 2024
Signed-off-by rafaelbn
@OCA-git-bot
Copy link
Contributor

@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1858-by-rafaelbn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@Shide
Copy link
Contributor Author

Shide commented Dec 16, 2024

@legalsylvain can you check failure of tests on your module when this module is merging? https://github.com/OCA/account-invoicing/actions/runs/12286819756/job/34287688237#step:8:189

@legalsylvain
Copy link
Contributor

@Shide which module ?

@Shide
Copy link
Contributor Author

Shide commented Dec 16, 2024

@legalsylvain
Copy link
Contributor

Sorry. I didn't implemented the "secondary currency" part (and never worked on multi currency). Better if another maintainer takes a look on that topic.

regards.

Copy link

@Gelojr Gelojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have discovered 2 errors:

@Shide Shide requested a review from Gelojr December 18, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants