Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] sale_order_invoicing_grouping_criteria: use odoo's grouping functions #1866

Draft
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

Tisho99
Copy link

@Tisho99 Tisho99 commented Dec 20, 2024

Odoo already has a grouping function that can be simply inherited to add more grouping criterias.

The function is declared in the sale module, and its used inside the _create_invoices function to group the values of the new invoices.

The module sale_order_invoicing_grouping_criteria currently uses a new custom way to group invoices.

Benefits of changing the grouping method:

  • Reduce the amount of customization and code
  • More compatibility with other odoo and oca modules

Cons of changing the grouping method:

  • Agrupation can only be done though fields present in the generated invoice. Fields only present in the sale, for example: sale id, can not be used in the agrupation (Thats why a test is commented, pending to solve)

T-6942

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@Tisho99 Tisho99 changed the title [IMP] sale_order_invoicing_grouping_criteria: use odoo's grouping functions [16.0][IMP] sale_order_invoicing_grouping_criteria: use odoo's grouping functions Dec 20, 2024
@Tisho99 Tisho99 force-pushed the 16.0-imp-sale_order_invoicing_grouping_criteria branch from 451b039 to 7938d2f Compare December 20, 2024 13:02
@Tisho99 Tisho99 force-pushed the 16.0-imp-sale_order_invoicing_grouping_criteria branch 2 times, most recently from 79819a1 to 8a7666f Compare December 23, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants