Skip to content

Commit

Permalink
Merge PR #1391 into 17.0
Browse files Browse the repository at this point in the history
Signed-off-by AaronHForgeFlow
  • Loading branch information
OCA-git-bot committed Jan 15, 2025
2 parents b194b2c + b703d9d commit 1de5235
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
14 changes: 8 additions & 6 deletions account_payment_partner/tests/test_account_payment_partner.py
Original file line number Diff line number Diff line change
Expand Up @@ -572,15 +572,17 @@ def test_account_move_payment_mode_id_default(self):
move_form = Form(
self.move_model.with_context(
default_name="Invoice test", default_move_type="out_invoice"
)
).with_company(self.env.ref("base.main_company").id)
)
self.assertFalse(move_form.payment_mode_id)
self.env["ir.default"].create(
{"field_id": field.id, "json_value": payment_mode.id}
)
self.env["ir.default"].with_company(
self.env.ref("base.main_company").id
).create({"field_id": field.id, "json_value": payment_mode.id})
move_form = Form(
self.move_model.with_context(
default_name="Invoice test", default_move_type="out_invoice"
)
default_name="Invoice test",
default_move_type="out_invoice",
default_company_id=self.env.ref("base.main_company").id,
).with_company(self.env.ref("base.main_company").id)
)
self.assertEqual(move_form.payment_mode_id, payment_mode)
4 changes: 2 additions & 2 deletions account_payment_purchase/models/account_move.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@ def _onchange_purchase_auto_complete(self):
"message": _("Selected purchase order have different payment mode."),
}
return res
elif self.payment_mode_id.id != new_mode:
elif new_mode and self.payment_mode_id.id != new_mode:
self.payment_mode_id = new_mode
if old_bank and new_bank and old_bank != new_bank:
res["warning"] = {
"title": _("Warning"),
"message": _("Selected purchase order have different supplier bank."),
}
elif self.partner_bank_id.id != new_bank:
elif new_bank and self.partner_bank_id.id != new_bank:
self.partner_bank_id = new_bank
return res

0 comments on commit 1de5235

Please sign in to comment.