Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX]payment order - fix compute_partner_bank_id #1164

Merged
merged 1 commit into from
Nov 6, 2023
Merged

[FIX]payment order - fix compute_partner_bank_id #1164

merged 1 commit into from
Nov 6, 2023

Conversation

luc-demeyer
Copy link
Contributor

The bank account number of then invoice is not selected when a supplier has multiple bank account numbers and there is no payment mode set on the vendor bill.
This PR fixes this issue.

@pedrobaeza pedrobaeza added this to the 14.0 milestone Nov 4, 2023
@luc-demeyer
[FIX] payment order: fix compute_partner_bank_id
ec143f5 
Fix _compute_partner_bank_id on account.move.line.
The bank account number of then invoice was not selected when a supplier has
multiple bank account numbers and there is no payment mode set on the
vendor bill. This PR corrects this issue.
@luc-demeyer luc-demeyer force-pushed the 14-fix-compute_partner_bank_id branch from e43ee1c to ec143f5 Compare November 5, 2023 15:27
This was referenced Nov 6, 2023
Merged
Merged
@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-1164-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 6, 2023
@OCA-git-bot
Merge PR #1164 into 14.0
4ddecf7 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1164-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza
pedrobaeza requested changes Nov 6, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, I'm now thinking that this is going to fill the bank account and fix it when it's imported in payment orders, which disables the feature of filling it on that case. Why do you want such behavior?

@alexis-via
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-1164-by-alexis-via-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 636bb2b into OCA:14.0 Nov 6, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bf6160c. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
Copy link
Member

@alexis-via I have put a requested changes review because I have now doubts. Can you please check them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza requested changes

@jdidderen-noviat jdidderen-noviat jdidderen-noviat approved these changes

@alexis-via alexis-via alexis-via approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@luc-demeyer @pedrobaeza @OCA-git-bot @alexis-via @jdidderen-noviat