[15.0][FIX] account_payment_order: Filter bank on company

[hhgabelgaard]

In multi company setup, we need to filter res.partner.bank for current (payment order) company, or shared partner bank account (No company set)

[pedrobaeza]

I understand that the problem is that you have selected more than one company at the same time when preparing the payment order. I think the cleanest patch should be to do self.partner_id.with_context(allowed_company_ids=self.company_id).bank_ids instead. What do you think?

[hhgabelgaard]

I understand that the problem is that you have selected more than one company at the same time when preparing the payment order.

No, Only one company selected. But this shouldn't depend on access / ir.rule

I think the cleanest patch should be to do
self.partner_id.with_context(allowed_company_ids=self.company_id).bank_ids instead. What do you think?

Didn't know that trick - And it seems to depend on access / ir.rules. i.e won't work in a background job run by the system user
My inspiration was how core does it, e.g. https://github.com/odoo/odoo/blob/15.0/addons/account/models/account_move.py#L532

[hhgabelgaard]

@pedrobaeza Your suggestions has been applied.
Thanks for the input/review

[pedrobaeza]

You have modified slightly my suggestions, why? Mine is more compact and descriptive.

[hhgabelgaard]

Because I assumed this [:1].id would fail with IndexError: tuple index out of range if the filtered list is empty....
As [0] does...
But It seems to work beautifully, and yes, it is more compact and descriptive.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[pedrobaeza]

/ocabot merge patch

Please fw-port it to upper versions.

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-1237-by-pedrobaeza-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 87a2308. Thanks a lot for contributing to OCA. ❤️