Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] [16.0] partner_risk_insurance_product_sticker_invoice_report #425

Conversation

Shide
Copy link

@Shide Shide commented Feb 11, 2025

Add Insurance Stickers to Invoice Reports when the Invoice is insured by a Credit company.

This PR must be merged before this one: OCA/account-invoice-reporting#351

MT-9075 @moduon @rafaelbn @yajo @EmilioPascual @fcvalgar please review if you want 😄

@Shide Shide force-pushed the 16.0-partner_risk_insurance_product_sticker_invoice_report branch from 866ae59 to 1c85bf3 Compare February 11, 2025 11:34
Copy link

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Code Review.

@yajo
Copy link
Member

yajo commented Feb 12, 2025

OCA/account-invoice-reporting#351 was merged. Please rebase to fix CI

@Shide Shide force-pushed the 16.0-partner_risk_insurance_product_sticker_invoice_report branch from 1c85bf3 to 0290911 Compare February 13, 2025 06:53
@rafaelbn rafaelbn added this to the 16.0 milestone Feb 13, 2025
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review,
LGTM, thank you @Shide

image

image

image

@Shide Shide force-pushed the 16.0-partner_risk_insurance_product_sticker_invoice_report branch from 0290911 to 6cf7bb6 Compare February 13, 2025 12:15
@Shide
Copy link
Author

Shide commented Feb 13, 2025

Thanks @fcvalgar, README updated according your suggestion.

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-425-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d7ad979. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit d3115ae into OCA:16.0 Feb 13, 2025
7 checks passed
@Shide Shide deleted the 16.0-partner_risk_insurance_product_sticker_invoice_report branch February 13, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants