-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][FIX] hr_attendance_rfid: Handle ValidationError properly #130
[13.0][FIX] hr_attendance_rfid: Handle ValidationError properly #130
Conversation
@lubusax please do not consider codecov warning, it is priority to keep branches even |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
44a687e
to
26a42fe
Compare
ping @OCA/human-resources-maintainers |
Instead of |
ok to me to use repr(e) |
This PR has the |
@lubusax I think the change won't affect how you handle the error message in the RFID device. Do you agree? I can supersede the PR if you want. |
@AaronHForgeFlow please supersede :) Let's get this done. Thank you |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
A ValidationError has to be converted to a string explicitly, otherwise an error is produced if is used as a string.