Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][FIX] hr_attendance_rfid: Handle ValidationError properly #130

Closed

Conversation

lubusax
Copy link

@lubusax lubusax commented May 30, 2023

A ValidationError has to be converted to a string explicitly, otherwise an error is produced if is used as a string.

@AaronHForgeFlow
Copy link
Contributor

@lubusax please do not consider codecov warning, it is priority to keep branches even

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 1, 2023
@lubusax lubusax changed the title [13.0][FIX] Handle ValidationError properly [13.0][FIX] hr_attendance_rfid: Handle ValidationError properly Oct 16, 2023
@lubusax lubusax force-pushed the 13.0]-FIX]-Handle-ValidationError-properly branch from 44a687e to 26a42fe Compare October 16, 2023 15:55
@AaronHForgeFlow
Copy link
Contributor

ping @OCA/human-resources-maintainers

@pedrobaeza pedrobaeza added this to the 13.0 milestone Oct 16, 2023
@pedrobaeza
Copy link
Member

Instead of str(e), I think it should be repr(e).

@AaronHForgeFlow
Copy link
Contributor

ok to me to use repr(e)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AaronHForgeFlow
Copy link
Contributor

@lubusax I think the change won't affect how you handle the error message in the RFID device. Do you agree? I can supersede the PR if you want.

@lubusax
Copy link
Author

lubusax commented Oct 17, 2023

@AaronHForgeFlow please supersede :) Let's get this done. Thank you

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 22, 2023
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 25, 2024
@pedrobaeza pedrobaeza closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants