[17.0][MIG] hr_attendance_report_theoretical_time: Migration to version 17.0 #173

juanjosesegui-tecnativa · 2024-08-02T07:23:43Z

juanjosesegui-tecnativa · 2024-08-07T07:09:12Z

pedrobaeza · 2024-08-07T11:37:14Z

/ocabot migration hr_attendance_report_theoretical_time

carolinafernandez-tecnativa

Functional review, LGTM.

Please squash administrative commits.
Check https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate for details.

carolinafernandez-tecnativa · 2024-08-07T11:50:45Z

hr_attendance_report_theoretical_time/tests/test_hr_attendance_report_theoretical_time.py

+from odoo.tests import common
+
+
+class TestHrAttendanceReportTheoreticalTimeBase(common.TransactionCase):


Please use BaseCommon

hr_attendance_report_theoretical_time/views/hr_employee_views.xml

carolinafernandez-tecnativa

Squashing administrative is still pending, please check my comments before thanks :)

carolinafernandez-tecnativa · 2024-08-07T15:37:51Z

hr_attendance_report_theoretical_time/tests/test_hr_attendance_report_theoretical_time.py

+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.env = cls.env(


When using BaseCommon it is not necessary to add this.

carolinafernandez-tecnativa · 2024-08-07T15:38:30Z

hr_attendance_report_theoretical_time/views/hr_employee_views.xml

+        <field name="res_model">recompute.theoretical.attendance</field>
+        <field name="binding_model_id" ref="model_hr_employee" />
+        <field name="view_mode">form</field>
+        <field name="context">{'default_employee_ids': id, 'employee_ids': id, }</field>


@pedrobaeza i am not sure if this is correct.

Ok, I will wait for Pedro's response to this change before pushing again with the squashing of the administrative commits.

No, it isn't. It's a x2m field, so it requires another nomenclature. Maybe [id], or [(4, id)], but it should be tried.

carolinafernandez-tecnativa · 2024-08-08T08:05:10Z

hr_attendance_report_theoretical_time/tests/test_hr_attendance_report_theoretical_time.py

+        cls.env(
+            context=dict(
+                cls.env.context,
+                mail_create_nolog=True,
+                mail_create_nosubscribe=True,
+                mail_notrack=True,
+                no_reset_password=True,
+                tracking_disable=True,
+            )


This should be removed when using BaseCommon

carolinafernandez-tecnativa

LGTM Thanks :)
Please remember to squash administrative commits

Theoretical vs Attended Time Analysis ===================================== This module adds a new report called "Theoretical vs Attended Time Analysis" that compares worked time, measured through attendances records, with the theoretical time, computed from employee's working calendar, public holidays and employee specific leaves. There is the possibility of counting as theoretical time some leave types if specified in them. Installation ============ On installation time, this module computes the theoretical hours for the day of the attendance check-in, so if you have a lot of records, this would be a bit slow. Configuration ============= You need to be at least "Attendance / Manual Attendance" for being able to see the attendances report. For including some leave types in the theoretical time, you have to: * Go to Leaves > Configuration. * Select leave type you want to include. * Check the mark "Include in theoretical hours". Usage ===== * Go to *Attendances > Reports > Theoretical vs Attended Time Analysis*. * Check pivot table or look at the graph view. Known issues / Roadmap ====================== * Employees with less than 1 week in the company will show full week theoretical hours. * Activate ORM cache for improving performance on computing theoretical hours, but assuring that the cache is cleared when the conditions of the computation changes. * If you change employee's working time, theoretical hours for non attended days will be computed according this new calendar. You have to define start and end dates inside the calendar for avoiding this side effect. * Recompute theoretical hours of affected days when changing the leave type to be included or not in theoretical time.

* Standard procedure * Adapt data model * Adapt views * Adapt code for date handling * Adapt tests [UPD] Update hr_attendance_report_theoretical_time.pot

…fault filter Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-12.0/hr-12.0-hr_attendance_report_theoretical_time Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_attendance_report_theoretical_time/

[UPD] Update hr_attendance_report_theoretical_time.pot hr_attendance_report_theoretical_time 12.0.1.1.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-12.0/hr-12.0-hr_attendance_report_theoretical_time Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_attendance_report_theoretical_time/

Currently translated at 97.6% (41 of 42 strings) Translation: hr-12.0/hr-12.0-hr_attendance_report_theoretical_time Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_attendance_report_theoretical_time/de/

- We add a wizard so the already existing attendances can be recomputed according to an employee calendar change, like a different for a set of dates that weren't took into consideration in advance, so the wrong theoretical hours are computed. [UPD] Update hr_attendance_report_theoretical_time.pot [UPD] README.rst hr_attendance_report_theoretical_time 12.0.1.2.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-12.0/hr-12.0-hr_attendance_report_theoretical_time Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_attendance_report_theoretical_time/

- Although the minor permission to access the theoretical time report is "Manual Attendance", the menu wasn't accessible due to permissions. - Record rules also prevent such users from seeing other employees attendances. hr_attendance_report_theoretical_time 12.0.1.3.0

…rm related to employee public (user without employee groups)

TT36461

victoralmau · 2024-08-08T11:52:03Z

hr_attendance_report_theoretical_time/reports/hr_attendance_theoretical_time_report_views.xml

        />
        <!-- We need to leave the action empty for consistency because we are going
            to set different submenus, otherwise the Reports menu would not be
            displayed to a basic user. !-->
        <field name="action" eval="False" />
    </record>
    <menuitem
-        id="menu_hr_attendance_report"
+        id="menu_hr_attendance_reporting"


I think this would not need to be changed.

In the hr_attendance module, they have changed "report" to "reporting."

That has nothing to do with this one, as this is a new XML-ID not linked with the main one. Please respect existing XML-IDs.

victoralmau · 2024-08-08T11:54:06Z

hr_attendance_report_theoretical_time/views/hr_employee_views.xml

@@ -10,7 +10,7 @@
        <field name="view_mode">form</field>
        <field
            name="context"
-        >{'default_employee_ids': active_ids, 'employee_ids': active_ids, }</field>
+        >{'default_employee_ids': [id], 'employee_ids': [id] }</field>


Please check this. If I try to use this action from an employee there is an error.

I can't find any errors.
If you test it again, please include a screenshot and I'll look into whether I can fix it. Thanks Victor

Thank you, I was only able to get it to work by reverting to using active_ids, even though it will be deprecated in Odoo 18. Right now, [id] or [(4, id)] don't work.

…doo/odoo@19f3a8d. TT36461

Tests rely on removing tz from the current user and it isn't possible anymore after odoo/odoo@d6f2437#diff-38469def2f870bb866f971f57797dd7c21b6a95d52a8eae72f832f0eea2434f9R105

Currently translated at 100.0% (53 of 53 strings) Translation: hr-attendance-15.0/hr-attendance-15.0-hr_attendance_report_theoretical_time Translate-URL: https://translation.odoo-community.org/projects/hr-attendance-15-0/hr-attendance-15-0-hr_attendance_report_theoretical_time/it/

…cover different use cases.

Currently translated at 100.0% (53 of 53 strings) Translation: hr-attendance-16.0/hr-attendance-16.0-hr_attendance_report_theoretical_time Translate-URL: https://translation.odoo-community.org/projects/hr-attendance-16-0/hr-attendance-16-0-hr_attendance_report_theoretical_time/es/

… a basic user We need to leave the action empty for consistency because we are going to set different submenus, otherwise the Reports menu would not be displayed to a basic user. TT44849

Currently translated at 47.1% (25 of 53 strings) Translation: hr-attendance-16.0/hr-attendance-16.0-hr_attendance_report_theoretical_time Translate-URL: https://translation.odoo-community.org/projects/hr-attendance-16-0/hr-attendance-16-0-hr_attendance_report_theoretical_time/fr/

juanjosesegui-tecnativa · 2024-08-13T11:12:33Z

All changes have been made and the administrative commits are squashed

ping @carolinafernandez-tecnativa

victoralmau

Functional review OK

OCA-git-bot · 2024-08-22T16:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza

/ocabot merge nobump

OCA-git-bot · 2024-08-24T17:01:57Z

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-173-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-08-24T17:05:56Z

Congratulations, your PR was merged at a45170b. Thanks a lot for contributing to OCA. ❤️

juanjosesegui-tecnativa force-pushed the 17.0-mig-hr_attendance_report_theoretical_time branch 3 times, most recently from 32b0863 to 6f9fa21 Compare August 2, 2024 10:09

juanjosesegui-tecnativa changed the title ~~[17.0][MIG] hr_employee_calendar_planning: Migration to version 17.0~~ [17.0][MIG] hr_attendance_report_theoretical_time: Migration to version 17.0 Aug 6, 2024

OCA-git-bot added this to the 17.0 milestone Aug 7, 2024

OCA-git-bot mentioned this pull request Aug 7, 2024

Migration to version 17.0 #154

Open

6 tasks

pedrobaeza requested review from victoralmau and carolinafernandez-tecnativa August 7, 2024 11:37

carolinafernandez-tecnativa reviewed Aug 7, 2024

View reviewed changes

juanjosesegui-tecnativa force-pushed the 17.0-mig-hr_attendance_report_theoretical_time branch from 6f9fa21 to a63a45f Compare August 7, 2024 13:38

carolinafernandez-tecnativa reviewed Aug 7, 2024

View reviewed changes

juanjosesegui-tecnativa force-pushed the 17.0-mig-hr_attendance_report_theoretical_time branch from a63a45f to ecbfd8b Compare August 8, 2024 07:44

carolinafernandez-tecnativa reviewed Aug 8, 2024

View reviewed changes

juanjosesegui-tecnativa force-pushed the 17.0-mig-hr_attendance_report_theoretical_time branch from ecbfd8b to 94adca0 Compare August 8, 2024 08:08

carolinafernandez-tecnativa approved these changes Aug 8, 2024

View reviewed changes

pedrobaeza and others added 13 commits August 8, 2024 10:26

[MIG] hr_attendance_report_theoretical_time: Migration to 12.0

f58da31

* Standard procedure * Adapt data model * Adapt views * Adapt code for date handling * Adapt tests [UPD] Update hr_attendance_report_theoretical_time.pot

[12.0][FIX] Travis Failing Holidays Leave Type Validity

91b8b86

Translated using Weblate (German)

677c75f

Currently translated at 97.6% (41 of 42 strings) Translation: hr-12.0/hr-12.0-hr_attendance_report_theoretical_time Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_attendance_report_theoretical_time/de/

[IMP] : black, isort

767d3fd

[MIG] 13.0 hr_attendance_report_theoretical_time

70a6e44

[FIX] Correct website in manifest

63f5367

[13.0][FIX] theoretical_time: Context was not imported on wizard

8795f35

[FIX] hr_attendance_report_theoretical_time: Show error in hr.lave fo…

3780572

…rm related to employee public (user without employee groups)

[MIG] hr_attendance_report_theoretical_time: Migration to 15.0

ab167c3

TT36461

juanjosesegui-tecnativa force-pushed the 17.0-mig-hr_attendance_report_theoretical_time branch from 94adca0 to aa87e38 Compare August 8, 2024 08:26

victoralmau suggested changes Aug 8, 2024

View reviewed changes

victoralmau and others added 9 commits August 8, 2024 15:38

[IMP] hr_attendance_report_theoretical_time: Reduce code according to o…

2a55041

…doo/odoo@19f3a8d. TT36461

[FIX] hr_attendance_report_theoretical_time: tests

66a3d70

Tests rely on removing tz from the current user and it isn't possible anymore after odoo/odoo@d6f2437#diff-38469def2f870bb866f971f57797dd7c21b6a95d52a8eae72f832f0eea2434f9R105

[IMP] hr_attendance_report_theoretical_time: Improve tests to better …

3f00d0c

…cover different use cases.

[MIG] hr_attendance_report_theoretical_time: Migration to 16.0

976797b

[FIX] hr_attendance_report_theoretical_time: Show the Reports menu to…

559a091

… a basic user We need to leave the action empty for consistency because we are going to set different submenus, otherwise the Reports menu would not be displayed to a basic user. TT44849

[IMP] hr_attendance_report_theoretical_time: pre-commit auto fixes

a64dba3

juanjosesegui-tecnativa force-pushed the 17.0-mig-hr_attendance_report_theoretical_time branch 3 times, most recently from 4b37c66 to 288660f Compare August 13, 2024 10:48

[MIG] hr_attendance_report_theoretical_time: Migration to 17.0

864202d

juanjosesegui-tecnativa force-pushed the 17.0-mig-hr_attendance_report_theoretical_time branch from 288660f to 864202d Compare August 22, 2024 07:31

victoralmau approved these changes Aug 22, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Aug 22, 2024

pedrobaeza approved these changes Aug 24, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Aug 24, 2024

OCA-git-bot merged commit 10ba59d into OCA:17.0 Aug 24, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Aug 24, 2024

pedrobaeza deleted the 17.0-mig-hr_attendance_report_theoretical_time branch August 24, 2024 17:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] hr_attendance_report_theoretical_time: Migration to version 17.0 #173

[17.0][MIG] hr_attendance_report_theoretical_time: Migration to version 17.0 #173

juanjosesegui-tecnativa commented Aug 2, 2024 •

edited

Loading

juanjosesegui-tecnativa commented Aug 7, 2024

pedrobaeza commented Aug 7, 2024

carolinafernandez-tecnativa left a comment

carolinafernandez-tecnativa Aug 7, 2024

carolinafernandez-tecnativa left a comment

carolinafernandez-tecnativa Aug 7, 2024

carolinafernandez-tecnativa Aug 7, 2024

juanjosesegui-tecnativa Aug 7, 2024

pedrobaeza Aug 7, 2024

carolinafernandez-tecnativa Aug 8, 2024

carolinafernandez-tecnativa left a comment •

edited

Loading

victoralmau Aug 8, 2024

juanjosesegui-tecnativa Aug 13, 2024

pedrobaeza Aug 13, 2024

victoralmau Aug 8, 2024

juanjosesegui-tecnativa Aug 13, 2024

victoralmau Aug 21, 2024

juanjosesegui-tecnativa Aug 22, 2024

juanjosesegui-tecnativa commented Aug 13, 2024

victoralmau left a comment

OCA-git-bot commented Aug 22, 2024

pedrobaeza left a comment

OCA-git-bot commented Aug 24, 2024

OCA-git-bot commented Aug 24, 2024

		from odoo.tests import common


		class TestHrAttendanceReportTheoreticalTimeBase(common.TransactionCase):

[17.0][MIG] hr_attendance_report_theoretical_time: Migration to version 17.0 #173

[17.0][MIG] hr_attendance_report_theoretical_time: Migration to version 17.0 #173

Conversation

juanjosesegui-tecnativa commented Aug 2, 2024 • edited Loading

juanjosesegui-tecnativa commented Aug 7, 2024

pedrobaeza commented Aug 7, 2024

carolinafernandez-tecnativa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carolinafernandez-tecnativa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carolinafernandez-tecnativa left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juanjosesegui-tecnativa commented Aug 13, 2024

victoralmau left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Aug 22, 2024

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Aug 24, 2024

OCA-git-bot commented Aug 24, 2024

juanjosesegui-tecnativa commented Aug 2, 2024 •

edited

Loading

carolinafernandez-tecnativa left a comment •

edited

Loading