Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] hr_attendance_report_theoretical_time: Migration to 18.0 #185

Open
wants to merge 40 commits into
base: 18.0
Choose a base branch
from

Conversation

@xaviedoanhduy xaviedoanhduy marked this pull request as draft October 14, 2024 10:59
@xaviedoanhduy xaviedoanhduy force-pushed the 18.0-mig-hr_attendance_report_theoretical_time branch 3 times, most recently from d303bf9 to f64ecfe Compare October 15, 2024 09:23
@xaviedoanhduy xaviedoanhduy force-pushed the 18.0-mig-hr_attendance_report_theoretical_time branch from f64ecfe to 7d356ca Compare October 16, 2024 11:16
@xaviedoanhduy xaviedoanhduy marked this pull request as ready for review October 16, 2024 18:48
@mmequignon
Copy link
Member

hi @xaviedoanhduy could you please not surround urls with ` ?
If you do so, urls aren't clickable, and it's more complicated for the reviewers.
Thank you !

@xaviedoanhduy
Copy link
Author

xaviedoanhduy commented Oct 21, 2024

hi @mmequignon,
thanks for the reminder.
I've updated.

@victoralmau
Copy link
Member

Please, cherry-pick #188 to commit history

@TDu
Copy link
Member

TDu commented Nov 5, 2024

Please, cherry-pick #188 to commit history

@xaviedoanhduy ⬆️ thank you

pedrobaeza and others added 19 commits November 6, 2024 09:04
Theoretical vs Attended Time Analysis
=====================================

This module adds a new report called "Theoretical vs Attended Time Analysis"
that compares worked time, measured through attendances records, with the
theoretical time, computed from employee's working calendar, public holidays
and employee specific leaves.

There is the possibility of counting as theoretical time some leave types if
specified in them.

Installation
============

On installation time, this module computes the theoretical hours for the day of
the attendance check-in, so if you have a lot of records, this would be a bit
slow.

Configuration
=============

You need to be at least "Attendance / Manual Attendance" for being able to see
the attendances report.

For including some leave types in the theoretical time, you have to:

* Go to Leaves > Configuration.
* Select leave type you want to include.
* Check the mark "Include in theoretical hours".

Usage
=====

* Go to *Attendances > Reports > Theoretical vs Attended Time Analysis*.
* Check pivot table or look at the graph view.

Known issues / Roadmap
======================

* Employees with less than 1 week in the company will show full week
  theoretical hours.
* Activate ORM cache for improving performance on computing theoretical hours,
  but assuring that the cache is cleared when the conditions of the computation
  changes.
* If you change employee's working time, theoretical hours for non attended
  days will be computed according this new calendar. You have to define
  start and end dates inside the calendar for avoiding this side effect.
* Recompute theoretical hours of affected days when changing the leave type
  to be included or not in theoretical time.
* Standard procedure
* Adapt data model
* Adapt views
* Adapt code for date handling
* Adapt tests

[UPD] Update hr_attendance_report_theoretical_time.pot
…fault filter

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-12.0/hr-12.0-hr_attendance_report_theoretical_time
Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_attendance_report_theoretical_time/
[UPD] Update hr_attendance_report_theoretical_time.pot

hr_attendance_report_theoretical_time 12.0.1.1.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-12.0/hr-12.0-hr_attendance_report_theoretical_time
Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_attendance_report_theoretical_time/
Currently translated at 97.6% (41 of 42 strings)

Translation: hr-12.0/hr-12.0-hr_attendance_report_theoretical_time
Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_attendance_report_theoretical_time/de/
- We add a wizard so the already existing attendances can be recomputed
according to an employee calendar change, like a different for a set of
dates that weren't took into consideration in advance, so the wrong
theoretical hours are computed.

[UPD] Update hr_attendance_report_theoretical_time.pot

[UPD] README.rst

hr_attendance_report_theoretical_time 12.0.1.2.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-12.0/hr-12.0-hr_attendance_report_theoretical_time
Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_attendance_report_theoretical_time/
- Although the minor permission to access the theoretical time report is
"Manual Attendance", the menu wasn't accessible due to permissions.
- Record rules also prevent such users from seeing other employees
attendances.

hr_attendance_report_theoretical_time 12.0.1.3.0
…rm related to employee public (user without employee groups)
… (context) when hr_attendance_theoretical_action is load from wizard
[UPD] Update hr_attendance_report_theoretical_time.pot

[UPD] README.rst
victoralmau and others added 15 commits November 6, 2024 09:04
…(including archived employees) in wizard

hr_attendance_report_theoretical_time 14.0.1.0.1
Currently translated at 96.1% (50 of 52 strings)

Translation: hr-attendance-14.0/hr-attendance-14.0-hr_attendance_report_theoretical_time
Translate-URL: https://translation.odoo-community.org/projects/hr-attendance-14-0/hr-attendance-14-0-hr_attendance_report_theoretical_time/bg/
…port

hr_attendance_report_theoretical_time 14.0.1.0.2
…the tests in TestHrAttendanceReportTheoreticalTimeBase to improve the inheritance of tests in other modules.

TT34898

hr_attendance_report_theoretical_time 14.0.1.0.3
…ate the total hours in two-week calendars with defined start and end dates (solved since odoo/odoo#96391).

TT34416

hr_attendance_report_theoretical_time 14.0.1.0.4
Currently translated at 100.0% (53 of 53 strings)

Translation: hr-attendance-15.0/hr-attendance-15.0-hr_attendance_report_theoretical_time
Translate-URL: https://translation.odoo-community.org/projects/hr-attendance-15-0/hr-attendance-15-0-hr_attendance_report_theoretical_time/it/
Currently translated at 100.0% (53 of 53 strings)

Translation: hr-attendance-16.0/hr-attendance-16.0-hr_attendance_report_theoretical_time
Translate-URL: https://translation.odoo-community.org/projects/hr-attendance-16-0/hr-attendance-16-0-hr_attendance_report_theoretical_time/es/
… a basic user

We need to leave the action empty for consistency because we are going
to set different submenus, otherwise the Reports menu would not be
displayed to a basic user.

TT44849
Currently translated at 47.1% (25 of 53 strings)

Translation: hr-attendance-16.0/hr-attendance-16.0-hr_attendance_report_theoretical_time
Translate-URL: https://translation.odoo-community.org/projects/hr-attendance-16-0/hr-attendance-16-0-hr_attendance_report_theoretical_time/fr/
@xaviedoanhduy xaviedoanhduy force-pushed the 18.0-mig-hr_attendance_report_theoretical_time branch from 7d356ca to 884a55e Compare November 6, 2024 02:07
@xaviedoanhduy
Copy link
Author

xaviedoanhduy commented Nov 6, 2024

Hello reviewers, cherry-picked the commits in #188 is done

Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could yo squash administrative commits?

@xaviedoanhduy xaviedoanhduy force-pushed the 18.0-mig-hr_attendance_report_theoretical_time branch from 884a55e to 358914f Compare November 6, 2024 09:04
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-attendance-17.0/hr-attendance-17.0-hr_attendance_report_theoretical_time
Translate-URL: https://translation.odoo-community.org/projects/hr-attendance-17-0/hr-attendance-17-0-hr_attendance_report_theoretical_time/
…y in the report

If only one company is selected, only the data of the employees of that company should be displayed.

TT51401
@xaviedoanhduy xaviedoanhduy force-pushed the 18.0-mig-hr_attendance_report_theoretical_time branch from 358914f to 69ecc2a Compare November 6, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.