[17.0][FIX] hr_holidays_public: fixed action_validate() override

[dalonsod]

Forward-port of #115

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[pedrobaeza]

Was this already fixed?

[dalonsod]

Tested in 17.0 runboat without this fix the bug case (trying to validate leaves that belong to more than one employee):

still fires an error:

Then, the fix seems to be required.

[dalonsod]

Anyway I'll take a look at existing merge conflicts ASAP and update this PR

[pedrobaeza]

/ocabot merge patch

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-116-by-pedrobaeza-bump-patch, awaiting test results.

[OCA-git-bot]

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-116-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[pedrobaeza]

Can you check CI?

[dalonsod]

Checked, and I don't know how to fix it. It fails when hr_holidays addon is trying to notify leave approval in a way I don't understand which modification in current code could lead to this error.

@dariodelzozzo could you help us?

[xaviedoanhduy]

Hello @dalonsod, this issue has been fixed already in this commit, So can you need to rebase this PR for tests to be green?

[pedrobaeza]

The rebase is done by the bot, so trying again

/ocabot merge patch

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-116-by-pedrobaeza-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at fdfbef9. Thanks a lot for contributing to OCA. ❤️