Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [MIG] hr_leave_custom_hour_interval: Migration to 16.0 #131

Merged
merged 11 commits into from
Sep 17, 2024
Merged

[16.0] [MIG] hr_leave_custom_hour_interval: Migration to 16.0 #131

merged 11 commits into from
Sep 17, 2024

Conversation

luisDIXMIT
Copy link

@luisDIXMIT luisDIXMIT commented Jul 4, 2024 •
edited
Loading

Standard migration

  • Added CONFIGURE.rst readme file and modified USAGE.rst
  • Added unit test

@etobella

@luisDIXMIT luisDIXMIT changed the title [16.0] [MIG] hr_leavecustom hour interval [16.0] [MIG] hr_leave_custom hour interval Jul 4, 2024
@luisDIXMIT luisDIXMIT changed the title [16.0] [MIG] hr_leave_custom hour interval [16.0] [MIG] hr_leave_custom_hour_interval: Migration to 16.0 Jul 4, 2024
@luisDIXMIT luisDIXMIT force-pushed the 16.0-mig-hr_leave_custom_hour_interval branch 2 times, most recently from 3077919 to ffcc930 Compare July 5, 2024 11:43
etobella
etobella approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pedrobaeza
Copy link
Member

/ocabot migration hr_leave_custom_hour_interval
/ocabot merge novump

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza. Your command failed:

Invalid options for command merge: novump.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 17, 2024
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot OCA-git-bot mentioned this pull request Sep 17, 2024
Open
7 tasks
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-131-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 17, 2024
@OCA-git-bot
Merge PR #131 into 16.0
f0d54e5 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-131-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

Please rebase to check the CI error.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

olgamarcocb and others added 10 commits September 17, 2024 09:45
@olgamarcocb @luisDIXMIT
[ADD] hr_leave_hour
f935416 
[UPD] Update hr_leave_hour.pot

[UPD] README.rst

[ADD] icon.png
@etobella @luisDIXMIT
[IMP] hr_leave_hour: Black, isort, prettier
669125b
@etobella @luisDIXMIT
[MIG] hr_leave_custom_hour_interval: Migration to 14.0
83eaa8b 
[UPD] Update hr_leave_custom_hour_interval.pot

[UPD] README.rst
@victoralmau @luisDIXMIT
[MIG] hr_leave_custom_hour_interval: Migration to 15.0
03db9cb 
TT41934
@luisDIXMIT
[UPD] Update hr_leave_custom_hour_interval.pot
6464c53
@OCA-git-bot @luisDIXMIT
[UPD] README.rst
092a151
@mymage @luisDIXMIT
Added translation using Weblate (Italian)
a4fff4b
@mymage @luisDIXMIT
Translated using Weblate (Italian)
5974292 
Currently translated at 100.0% (5 of 5 strings)

Translation: hr-holidays-15.0/hr-holidays-15.0-hr_leave_custom_hour_interval
Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-15-0/hr-holidays-15-0-hr_leave_custom_hour_interval/it/
@OCA-git-bot @luisDIXMIT
[UPD] README.rst
6acbc68
@luisDIXMIT
[IMP] hr_leave_custom_hour_interval: pre-commit auto fixes
776b5dc
@luisDIXMIT luisDIXMIT force-pushed the 16.0-mig-hr_leave_custom_hour_interval branch from ffcc930 to 6ae493f Compare September 17, 2024 07:45
@luisDIXMIT luisDIXMIT force-pushed the 16.0-mig-hr_leave_custom_hour_interval branch from 6ae493f to edc1aa1 Compare September 17, 2024 09:43
@luisDIXMIT
Copy link
Author

@pedrobaeza fixed!!

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-131-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3664a77 into OCA:16.0 Sep 17, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 757cdef. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etobella etobella etobella approved these changes

@janikvonrotz janikvonrotz janikvonrotz approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
8 participants
@luisDIXMIT @pedrobaeza @OCA-git-bot @janikvonrotz @etobella @olgamarcocb @victoralmau @mymage