[16.0][FIX] hr_holidays_public*: Use the context employee or the user's employee

[victoralmau]

FWP from 15.0: #130

Locked by:

• web: [16.0][IMP] web: Add context to fetchUnusualDays() odoo/odoo#172380

Use the context employee or the user's employee

Use case:

• Go to Employees to an employee with a different address (country) than our own and with specific public holidays for that country.
• Go to the Time-off smart-buttons
• We will have to see there the public holidays according to the employee's address

Please @pedrobaeza and @carolinafernandez-tecnativa can you review it?

@Tecnativa TT49839

[carolinafernandez-tecnativa]

Funcional review LGTM, Thanks :)

[pedrobaeza]

@carolinafernandez-tecnativa this isn't working without the Odoo patch. How have you reviewed it functionally?

[carolinafernandez-tecnativa]

I attached the examples:

1. Configure public Holidays for Country United States

2- Go to an employee that is not the same as user logged in (for example Eli)

3- Press Time-off button

And calendar its okay.

[pedrobaeza]

But that's the question: you have to try with an employee with a different country than ours.

[carolinafernandez-tecnativa]

Ok could you please add that in Use case PR description? Thanks!

[pedrobaeza]

The PR description is indicating this same use case. It's a bugfix, so nothing to go on the README itself. You have to check the why of the PR, and ask for more details in they are not clear in the PR description.

[pedrobaeza]

Re-reading, it's true that the description is not specific about the different address. It should be:

* Go to Employees to an employee with a different address (country) than our
  own and with specific public holidays for that country.

[victoralmau]

Odoo has already merged the related PR.

Can you check it now?

[pedrobaeza]

/ocabot merge patch

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-132-by-pedrobaeza-bump-patch, awaiting test results.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[OCA-git-bot]

Congratulations, your PR was merged at 05881b1. Thanks a lot for contributing to OCA. ❤️