[16.0][MIG] hr_holidays_credit: Migration to 16.0 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 21.4% (3 of 14 strings) Translation: hr-12.0/hr-12.0-hr_holidays_credit Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_credit/fr/
Currently translated at 100.0% (14 of 14 strings) Translation: hr-12.0/hr-12.0-hr_holidays_credit Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_credit/fr/
Currently translated at 35.2% (6 of 17 strings) Translation: hr-holidays-14.0/hr-holidays-14.0-hr_holidays_credit Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-14-0/hr-holidays-14-0-hr_holidays_credit/hr/
Currently translated at 100.0% (17 of 17 strings) Translation: hr-holidays-14.0/hr-holidays-14.0-hr_holidays_credit Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-14-0/hr-holidays-14-0-hr_holidays_credit/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-holidays-14.0/hr-holidays-14.0-hr_holidays_credit Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-14-0/hr-holidays-14-0-hr_holidays_credit/
Currently translated at 100.0% (17 of 17 strings) Translation: hr-holidays-14.0/hr-holidays-14.0-hr_holidays_credit Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-14-0/hr-holidays-14-0-hr_holidays_credit/es/
AaronHForgeFlow
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
It works good, just please add some explanation on tests methods please.
I think this integration with v16 is ok. Now that Odoo added the option "Requires allocation" it makes sense that the "Allow credit" option is available only when the allocation is required.
| cls.SudoAllocation = cls.Allocation.sudo() | ||
|
|
||
| def test_1(self): | ||
| employee = self.SudoEmployee.create({"name": "Employee #1"}) |
There was a problem hiding this comment.
Suggested change
| employee = self.SudoEmployee.create({"name": "Employee #1"}) | |
| """ | |
| Test that creating a leave without allowing credit raises a ValidationError, | |
| and succeeds after enabling credit on the leave type. | |
| """ | |
| employee = self.SudoEmployee.create({"name": "Employee #1"}) |
| ) | ||
|
|
||
| def test_2(self): | ||
| department = self.SudoDepartment.create({"name": "Department #2"}) |
There was a problem hiding this comment.
Suggested change
| department = self.SudoDepartment.create({"name": "Department #2"}) | |
| """ | |
| Test that leave allocation validation respects department restrictions. | |
| Leaves for employees in allowed departments succeed, while others raise ValidationError. | |
| """ | |
| department = self.SudoDepartment.create({"name": "Department #2"}) |
| } | ||
| ) | ||
|
|
||
| def test_3(self): |
There was a problem hiding this comment.
"""
Test that leave allocation validation respects individual employee credit restrictions.
Leaves for employees with credit allowed succeed, while others raise ValidationError.
"""
| ) | ||
|
|
||
| def test_4(self): | ||
| employee = self.SudoEmployee.create({"name": "Employee #4"}) |
There was a problem hiding this comment.
Suggested change
| employee = self.SudoEmployee.create({"name": "Employee #4"}) | |
| """ | |
| Test the name_get method | |
| """ | |
| employee = self.SudoEmployee.create({"name": "Employee #4"}) |
| self.assertTrue("credit" not in name) | ||
|
|
||
| def test_5(self): | ||
| employee = self.SudoEmployee.create({"name": "Employee #5"}) |
There was a problem hiding this comment.
Suggested change
| employee = self.SudoEmployee.create({"name": "Employee #5"}) | |
| """ | |
| Test that the name_get method includes 'available + credit' in the leave type name | |
| when credit is allowed. | |
| """ | |
| employee = self.SudoEmployee.create({"name": "Employee #5"}) |
| self.assertTrue("available + credit" in name) | ||
|
|
||
| def test_6(self): | ||
| employee = self.SudoEmployee.create({"name": "Employee #6"}) |
There was a problem hiding this comment.
Suggested change
| employee = self.SudoEmployee.create({"name": "Employee #6"}) | |
| """ | |
| Test that the name_get method includes 'used in credit' in the leave type name | |
| when a leave consumes credit. | |
| """ | |
| employee = self.SudoEmployee.create({"name": "Employee #6"}) |
LauraCForgeFlow
force-pushed
the
16.0-mig-hr_holidays_credit
branch
from
710496a
to
564069c
Compare
|
@AaronHForgeFlow Done, thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.