Skip to content

Commit

Permalink
[REF] l10n_br_account_payment_brcobranca: Solve 'E8106(external-reque…
Browse files Browse the repository at this point in the history
…st-timeout) Use of external request method without timeout. It could wait for a long time.'
  • Loading branch information
mbcosta committed Aug 15, 2024
1 parent 9baace4 commit b63debd
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 3 deletions.
2 changes: 2 additions & 0 deletions l10n_br_account_payment_brcobranca/constants/br_cobranca.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
from odoo.exceptions import UserError
from odoo.tools import config

TIMEOUT = 300 # seconds

DICT_BRCOBRANCA_CNAB_TYPE = {
"240": "cnab240",
"400": "cnab400",
Expand Down
9 changes: 7 additions & 2 deletions l10n_br_account_payment_brcobranca/models/account_move.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from odoo import _, models
from odoo.exceptions import UserError

from ..constants.br_cobranca import get_brcobranca_api_url
from ..constants.br_cobranca import TIMEOUT, get_brcobranca_api_url

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -71,7 +71,12 @@ def _get_brcobranca_boleto(self, boletos):
brcobranca_service_url,
self.name,
)
res = requests.post(brcobranca_service_url, data={"type": "pdf"}, files=files)
res = requests.post(

Check warning on line 74 in l10n_br_account_payment_brcobranca/models/account_move.py

View check run for this annotation

Codecov / codecov/patch

l10n_br_account_payment_brcobranca/models/account_move.py#L74

Added line #L74 was not covered by tests
brcobranca_service_url,
data={"type": "pdf"},
files=files,
timeout=TIMEOUT,
)

if str(res.status_code)[0] == "2":
pdf_string = res.content
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

from ..constants.br_cobranca import (
DICT_BRCOBRANCA_CNAB_TYPE,
TIMEOUT,
get_brcobranca_api_url,
get_brcobranca_bank,
)
Expand Down Expand Up @@ -182,6 +183,7 @@ def _get_brcobranca_remessa(self, bank_brcobranca, remessa_values, cnab_type):
"bank": bank_brcobranca.name,
},
files=files,
timeout=TIMEOUT,
)

if cnab_type == "240" and "R01" in res.text[242:254]:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

from odoo.addons.account_move_base_import.parser.file_parser import FileParser

from ..constants.br_cobranca import get_brcobranca_api_url
from ..constants.br_cobranca import TIMEOUT, get_brcobranca_api_url

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -91,6 +91,7 @@ def _get_brcobranca_retorno(self, files):
"bank": bank_name_brcobranca,
},
files=files,
timeout=TIMEOUT,
)

if res.status_code != 201:
Expand Down

0 comments on commit b63debd

Please sign in to comment.