Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG][l10n_br_account] #2865

Merged
merged 1,440 commits into from
Aug 23, 2024
Merged

Conversation

rvalyi
Copy link
Member

@rvalyi rvalyi commented Jan 16, 2024

depende de:

é construído a partir do PR da migração do l10n_br_account para a v15: #2806

No momento falta migrar o método account.move#_compute_amount e os dados dos testes foram adaptados para passar mesmo com esse método para migrar. Ou seja: os lançamentos nos account.move.line parecem OK, mas os totais ao nível do account.move ainda precisam de retrabalho.
Tem alguns outros ajustes menores para fazer também.

@rvalyi rvalyi force-pushed the 16.0-mig-l10n_br_account branch 6 times, most recently from 576f132 to 3511a81 Compare January 16, 2024 18:18
@rvalyi rvalyi marked this pull request as draft January 16, 2024 18:18
@rvalyi rvalyi force-pushed the 16.0-mig-l10n_br_account branch 2 times, most recently from 1ad7a3f to abfa004 Compare January 16, 2024 18:36
@rvalyi
Copy link
Member Author

rvalyi commented Jan 16, 2024

/ocabot migration l10n_br_account

@rvalyi
Copy link
Member Author

rvalyi commented Feb 5, 2024

dei um rebase para ficar mais facil testar esse PR

@rvalyi
Copy link
Member Author

rvalyi commented Feb 6, 2024

pessoal é bom testar o PR, porem vale lembrar que o metodo _compute_amounts não foi migrado ainda assim que eu expliquei em #2865 (comment)

Copy link
Member

@mileo mileo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se for só pra ajudar na migração dos outros módulos e corrigir o método _compute_amount depois por mim ta OK.

@rvalyi
Copy link
Member Author

rvalyi commented Feb 6, 2024

_compute_amount

é provável que sem terminar de migrar o _compute_amounts muitos tests não vão passar nos outros módulos, mas da para começar a ajeitar os outros PRs isso sim...

@marcelsavegnago
Copy link
Member

@rvalyi róla um rebase ?

@rvalyi
Copy link
Member Author

rvalyi commented Feb 9, 2024

@rvalyi róla um rebase ?

feito.

@rvalyi
Copy link
Member Author

rvalyi commented Aug 23, 2024

pessoal, dei um rebase so para mostrar que continuiu tudo bem com o modulo l10n_br_account_payment_brcobranca que teve merge de manha.

@marcelsavegnago
Copy link
Member

Bora mesclar essssa p0rr@ :D

@marcelsavegnago
Copy link
Member

@antoniospneto bora ?

@marcelsavegnago
Copy link
Member

@douglascstd bora ?

@antoniospneto
Copy link
Contributor

@marcelsavegnago @rvalyi

Eu não cheguei analisar ainda as últimas alterações, mas concordo em fazer o merge agora.
Ai fica mais facil para depois abrir as outras PRs com as correções restantes.

@marcelsavegnago
Copy link
Member

@renatonlima ?

@renatonlima
Copy link
Member

Bora fazer o merge

@renatonlima
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2865-by-renatonlima-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 08420a3 into OCA:16.0 Aug 23, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 59ffb6b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.