Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] l10n_br_fiscal: fix validation error message #3184

Merged

Conversation

marcelsavegnago
Copy link
Member

Traceback (most recent call last):
  File "/opt/odoo/custom/src/odoo/odoo/http.py", line 652, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/opt/odoo/custom/src/odoo/odoo/http.py", line 317, in _handle_exception
    raise exception.with_traceback(None) from new_cause
ValueError: unsupported format character '!' (0x21) at index 77

@OCA-git-bot
Copy link
Contributor

Hi @renatonlima,
some modules you are maintaining are being modified, check this out!

Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nao sei se essa forma eh boa... Pois assim ele vai tentar traduzir e depois formatar, ou seja pode falhar de acordo com o que tiver na traduçao. A forma como tende a ser feito no Odoo hoje eh:
_("blah blah blah %(variable1)s blah blah blah %(variable2)s", variable1=some_value1, variable2=some_value2)

Ou seja faltou o s depois do %(state) e tb tem que tirar o format.

@marcelsavegnago
Copy link
Member Author

Nao sei se essa forma eh boa... Pois assim ele vai tentar traduzir e depois formatar, ou seja pode falhar de acordo com o que tiver na traduçao. A forma como tende a ser feito no Odoo hoje eh: _("blah blah blah %(variable1)s blah blah blah %(variable2)s", variable1=some_value1, variable2=some_value2)

Ou seja faltou o s depois do %(state) e tb tem que tirar o format.

Opa... blzz.. vou corrigir

@marcelsavegnago marcelsavegnago force-pushed the 14.0-l10n_br_fiscal-fix-unlink-raise-message branch from 2081fae to 743288b Compare July 19, 2024 22:48
@marcelsavegnago
Copy link
Member Author

@rvalyi feito

@rvalyi
Copy link
Member

rvalyi commented Jul 20, 2024

nao tem que tirar o format ainda?

@marcelsavegnago
Copy link
Member Author

nao tem que tirar o format ainda?

Opss

@marcelsavegnago marcelsavegnago force-pushed the 14.0-l10n_br_fiscal-fix-unlink-raise-message branch from 743288b to 2982135 Compare July 22, 2024 14:09
@marcelsavegnago
Copy link
Member Author

@rvalyi feito

Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agora sim

@renatonlima
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-3184-by-renatonlima-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8a420e4 into OCA:14.0 Jul 22, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 847c85d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants