-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][FIX] l10n_br_fiscal: fix validation error message #3184
[14.0][FIX] l10n_br_fiscal: fix validation error message #3184
Conversation
marcelsavegnago
commented
Jul 19, 2024
Hi @renatonlima, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nao sei se essa forma eh boa... Pois assim ele vai tentar traduzir e depois formatar, ou seja pode falhar de acordo com o que tiver na traduçao. A forma como tende a ser feito no Odoo hoje eh:
_("blah blah blah %(variable1)s blah blah blah %(variable2)s", variable1=some_value1, variable2=some_value2)
Ou seja faltou o s depois do %(state) e tb tem que tirar o format.
Opa... blzz.. vou corrigir |
2081fae
to
743288b
Compare
@rvalyi feito |
nao tem que tirar o format ainda? |
Opss |
743288b
to
2982135
Compare
@rvalyi feito |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agora sim
/ocabot merge minor |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 847c85d. Thanks a lot for contributing to OCA. ❤️ |