Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] l10n_br_stock_account: no longer reads fop from null sale/purchase #3288

Merged
merged 2 commits into from
Aug 18, 2024
Merged

[14.0][FIX] l10n_br_stock_account: no longer reads fop from null sale/purchase #3288

merged 2 commits into from
Aug 18, 2024

Conversation

DiegoParadeda
Copy link
Contributor

Este PR corrige o funcionamento da operação fiscal padrão na transferência de estoque

exemplo:
image
image

@DiegoParadeda
Copy link
Contributor Author

DiegoParadeda commented Aug 16, 2024 •
edited
Loading

Pessoal, avaliando melhor o resultado dos testes percebi que o getattr realmente não está funcionando legal nessa função.

Por se tratar de compute default, caí em alguns casos em que os registros ainda estavam sendo criados (self = model()). Isso torna impossível verificar a situação da PO/SO pra observar se a fop está preenchida.

Para o caso da SO isso não é problema, pois a operação já está sendo carregada corretamente.
Para a PO mudei o comportamento para apontar a fop como vazia no momento da criação do dicionário de valores. Vou só verificar a compatibilidade com o caso internacional agora

@DiegoParadeda DiegoParadeda reopened this Aug 16, 2024
rvalyi
rvalyi approved these changes Aug 17, 2024
View reviewed changes
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvalyi
Copy link
Member

rvalyi commented Aug 17, 2024 •
edited
Loading

@DiegoParadeda o patch ta OK, porem no futuro seria bom vc respeitar o guideline de commit da OCA
https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message
ou seja: botar o nome do modulo no inicio. Isso ajuda depois para a gente controlar as coisas quando a gente sincronisa as branches das varias versoes...

@rvalyi
Copy link
Member

rvalyi commented Aug 18, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-3288-by-rvalyi-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f48721c into OCA:14.0 Aug 18, 2024
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0bf6c07. Thanks a lot for contributing to OCA. ❤️

@mbcosta mbcosta mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvalyi rvalyi rvalyi approved these changes

@antoniospneto antoniospneto Awaiting requested review from antoniospneto

@mbcosta mbcosta Awaiting requested review from mbcosta

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DiegoParadeda @rvalyi @OCA-git-bot @antoniospneto @mbcosta