[14.0][FIX] l10n_br_fiscal: ncm starting with 09 conflicts with service type #3469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @renatonlima, |
|
@crsilveira se puder revisar. |
antoniospneto
approved these changes
Oct 28, 2024
mileo
approved these changes
Oct 28, 2024
kaynnan
approved these changes
Oct 29, 2024
Assim funciona. |
|
@renatonlima de acordo dessa forma? |
|
Já tem um tempo que esse onchange da problema, em alguns clientes eu já tinha inclusive desativado. Desta forma ficou melhor. |
CristianoMafraJunior
force-pushed
the
14.0-fix-ncm_conflict
branch
from
cb52f1b
to
4bdb6e9
Compare
antoniospneto
approved these changes
Oct 30, 2024
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
@OCA/local-brazil-maintainers Pessoal, eu dei merge pois as alterações já estão conforme @renatonlima sugeriu em #3096 (review) |
This was referenced Oct 30, 2024
Merged
|
Congratulations, your PR was merged at b9b7997. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrumei o codigo conforme foi feita a revisão na PR anterior, se estiver tudo certo e for aprovado faço os fwp.
Substituindo a PR #3096 para fechar a Issue #3095
VIDEO_TESTE_NCM.mp4