Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0] Add option to show account details before KPI on instance #572

Open
wants to merge 4 commits into
base: 15.0
Choose a base branch
from
Open

[15.0] Add option to show account details before KPI on instance #572

wants to merge 4 commits into from

Conversation

sa3m
Copy link

@sa3m sa3m commented Oct 5, 2023 •
edited
Loading

Hello,

I added an option to show the detail of the accounts before the KPI (requested by my customer).
I thought it might interest the community.
I know it lacks unit tests but it can be added if the feature is found useful.

Cheers,

Samuel

@OCA-git-bot
Copy link
Contributor

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

@sa3m sa3m changed the title Add inverse detail option to instance [15.0] Add inverse detail option to instance Oct 5, 2023
sbidoul
sbidoul reviewed Oct 5, 2023
View reviewed changes
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contrib.
This sounds useful to me and the implementation looks ok.
I made a few minor comments.
And a test, yes :)

mis_builder/models/kpimatrix.py Outdated Show resolved Hide resolved
mis_builder/models/mis_report_instance.py Outdated Show resolved Hide resolved
mis_builder/views/mis_report_instance.xml Outdated Show resolved Hide resolved
@sa3m sa3m changed the title [15.0] Add inverse detail option to instance [15.0] Add option to show account details before KPI on instance Oct 5, 2023
@sa3m
Copy link
Author

sa3m commented Oct 10, 2023

I added 2 tests (without and with the setting). I had to add it in test_data_sources to have proper data to test it on.
Tell me if it's okay with you.

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 11, 2024
@sbidoul sbidoul removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 11, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 16, 2024
@github-actions github-actions bot closed this Jul 21, 2024
@sbidoul sbidoul reopened this Jul 23, 2024
@OCA-git-bot
Copy link
Contributor

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbidoul sbidoul sbidoul left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sa3m @OCA-git-bot @sbidoul