[14.0][IMP] mis_builder: Filter period by company #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sbidoul, |
etobella
force-pushed
the
14.0-column-company
branch
from
e7df28d
to
1b865a0
Compare
|
LGTM. This must not be ported beyond 15 because in 16, the analytic domain covers the use case, is that correct? |
|
You are right @sbidoul It seems easier to configure, but it is not necessary |
|
BTW, we had backport part of the analytic domain feature to 14 in #565. |
|
In this case, we can remove this PR. WDYT? |
|
As you prefer, either we keep it (and forward port it) if you think an easier mechanism is necessary for company filters, or we remove it. |
|
With the new mechanism it is not needed, so I would recommend to refuse it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #183 inside the core