[16.0] Custom fields in accounting expressions (e.g. fldp.quantity)
#584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
force-pushed
the
16.0-custom-fld
branch
3 times, most recently
from
659cd36
to
04328ad
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
sbidoul
removed
the
stale
sbidoul
changed the title
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
sbidoul
removed
the
stale
sbidoul
added
the
no stale
sbidoul
force-pushed
the
16.0-custom-fld
branch
from
14b2cef
to
0e63372
Compare
Now that there is a default value for the debit/credit in the accumulator, we can simplify.
and prepare for custom fields
sbidoul
force-pushed
the
16.0-custom-fld
branch
from
0e63372
to
4abfe17
Compare
sbidoul
force-pushed
the
16.0-custom-fld
branch
from
4abfe17
to
1e2aed9
Compare
|
This is ready to go. I added tests and documentation. Very useful to combine quantities (say, hours) with accounting data in the same MIS report. |
sbidoul
changed the title
fldp.quantity)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very rough experiment on the Accounting Expression Processor to support expressions such as
fldp.quantity[60%]This will read the quantity field in the same read_group as debit and credit so we can write efficient expressions on any numerical field that is available in the move-line-like table.
TODO