Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][IMP] add: css sticky table header added for mis-builder-widget #588

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

dora-jurcevic
Copy link

Hello !
Here is the modification of the CSS of the table header on mis-builder preview, making the header stick on the top of the page. Only CSS has been modified.
Thank you in advance for the review,
This is my first PR, so please be gentile :)

@OCA-git-bot
Copy link
Contributor

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Tested on runboat 👍

@vdewulf
Copy link
Contributor

vdewulf commented Nov 20, 2023

Tested in runboat, the budget report is very long and when I scroll down, the column titles remain visible.
Cf. screeshot.
Selection_450
Thanks @dora-jurcevic !

Copy link
Contributor

@vdewulf vdewulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in runboat (see previous comment).
Functionally Approved!

@dora-jurcevic
Copy link
Author

Wow, this was quick ! I am sure it's all part of the new welcome package for OCA newbies ;)
Special thanks to @bguillot who helped me with the PR

@sbidoul
Copy link
Member

sbidoul commented Nov 21, 2023

/ocabot merge patch

Do you plan to port this to 16?

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-588-by-sbidoul-bump-patch, awaiting test results.

@dora-jurcevic
Copy link
Author

/ocabot merge patch

Do you plan to port this to 16?

Yes ! Next step, the same feature on V16 !

@OCA-git-bot
Copy link
Contributor

@sbidoul The merge process could not be finalized, because command git push origin 14.0-ocabot-merge-pr-588-by-sbidoul-bump-patch:14.0 failed with output:

To https://github.com/OCA/mis-builder
 ! [rejected]          14.0-ocabot-merge-pr-588-by-sbidoul-bump-patch -> 14.0 (fetch first)
error: failed to push some refs to 'https://***@github.com/OCA/mis-builder'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

@OCA-git-bot OCA-git-bot merged commit 986d931 into OCA:14.0 Nov 21, 2023
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2cd5a7c. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
Copy link
Member

And v15, please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants