[16.0][IMP] mis_builder: preserve the filters when navigating back from drill-down #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IT-Ideas
force-pushed
the
16.0-mis-builder_preserve_search-lst
branch
from
914cf12
to
ae2428d
Compare
IT-Ideas
changed the title
IT-Ideas
force-pushed
the
16.0-mis-builder_preserve_search-lst
branch
2 times, most recently
from
2e681e1
to
7c2fc76
Compare
IT-Ideas
force-pushed
the
16.0-mis-builder_preserve_search-lst
branch
2 times, most recently
from
7c07791
to
b0692f8
Compare
sbidoul
changed the title
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
Hi @sbidoul, |
sbidoul
removed
the
stale
This commit ensure that the context used by the `mis_report_widget` widget RPC calls is correctly computed. Previously using the `mis_analytic_domain` context key was useless as not taken into account in the widget.
sbidoul
force-pushed
the
16.0-mis-builder_preserve_search-lst
branch
from
b0692f8
to
36c3250
Compare
…ll-down Prior to this commit the state of the searchModel was lost when navigating back from a drill-down. This commit uses the globalState in order to store and restore the state of the searchModlel. The use of a SubEnv allows not having to pass props up to the widget, which would have required overriding the renderer, the compiler and field.
sbidoul
force-pushed
the
16.0-mis-builder_preserve_search-lst
branch
from
36c3250
to
2ccb025
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the state of the searchModel was lost when navigating
back from a drill-down.
This commit uses the globalState in order to store and restore the state
of the searchModlel. The use of a SubEnv allows not having to pass props
up to the widget, which would have required overriding the renderer, the
compiler and field.
Blocked by #585