[16.0][FIX] mis_builder: python 3.9 compatibility #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sbidoul, |
sbidoul
changed the title
sbidoul
reviewed
Feb 8, 2024
mis_builder/models/aep.py
Outdated
| @@ -543,4 +543,4 @@ def get_unallocated_pl(cls, companies, date): | |||
| # TODO shoud we include here the accounts of type "unaffected" | |||
| # or leave that to the caller? | |||
| bals = cls._get_balances(cls.MODE_UNALLOCATED, companies, date, date) | |||
| return tuple(map(sum, zip(*bals.values(), strict=True))) | |||
| return tuple(map(sum, zip(*bals.values()))) # noqa | |||
There was a problem hiding this comment.
Suggested change
| return tuple(map(sum, zip(*bals.values()))) # noqa | |
| return tuple(map(sum, zip(*bals.values()))) # noqa: XXXX |
Silence the specific warning, for documentation and precision.
| @@ -0,0 +1 @@ | |||
| Error when running on official Odoo Docker image using Python 3.9 | |||
There was a problem hiding this comment.
Suggested change
| Error when running on official Odoo Docker image using Python 3.9 | |
| Restore compatibility with python 3.9 |
Make the code compatible with Python 3.9 to allow using official Odoo Docker containers
ivs-cetmix
force-pushed
the
16.0-t3281-mis_builder-python_3_9-compatability
branch
from
09c31af
to
203ec4a
Compare
|
Thank you @sbidoul ! I have applied the suggested updates. Could you please check again? |
sbidoul
approved these changes
Feb 8, 2024
rvalyi
reviewed
Feb 8, 2024
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 3aea423. Thanks a lot for contributing to OCA. ❤️ |
ivs-cetmix
deleted the
16.0-t3281-mis_builder-python_3_9-compatability
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the code compatible with Python 3.9 to allow using official Odoo Docker containers
Closes #590