[IMP][16.0] mis_builder: allow definition of style expression on subkpi level

[AnizR]

Description

Solves issue: #614

The goal is to be able to define a style on a cell. Therefore, this PR allows to define a style on a subkpi:

On my row, I will have my cell with KPI_1 in red and my cell with KPI_2 without any style.

Remark

There are now 3 ways to define a style:

1. Style on a KPI
2. Style expression on a KPI
3. Style expression in expressions of a KPI

The sytle defined in [3] has priority over [2] which has priority over [1].

[OCA-git-bot]

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

[AnizR]

I've add a small fix: when a style expression was defined, it was only used to set style of cell but not style of number (it was ignoring rounding,prefix, etc.)

[SAnnabelle]

Functionally, it's correct.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[sbidoul]

Can you also add a style on the mis.report.kpi, for completeness and symmetry with the styling of the kpi?

[sbidoul]

Can you also add a style on the mis.report.kpi, for completeness and symmetry with the styling of the kpi?

Or, before doing that can you explain why you chose to do a style expression instead of a style m2o. The latter seems easier to use.

[AnizR]

Can you also add a style on the mis.report.kpi, for completeness and symmetry with the styling of the kpi?

I suppose that you meant mis.report.kpi.expression

Or, before doing that can you explain why you chose to do a style expression instead of a style m2o. The latter seems easier to use.

The style seems 'easier' to use but in my case, it wasn't enough: I want to be able to change my style depending on multiple conditions.

Nonetheless, I'll add it for completeness

[sbidoul]

Can you also add a style on the mis.report.kpi, for completeness and symmetry with the styling of the kpi?

I suppose that you meant mis.report.kpi.expression

Yes. A style on mis.report.kpi might be useful, but it's another story.

[AnizR]

Can you also add a style on the mis.report.kpi, for completeness and symmetry with the styling of the kpi?

I suppose that you meant mis.report.kpi.expression

Yes. A style on mis.report.kpi might be useful, but it's another story.

It is already implemented on mis.report.kpi:

mis-builder/mis_builder/models/mis_report.py

Line 106 in bc5b7d1

style_id = fields.Many2one(

But indeed, adding it on mis.report.kpi.expression is complex

The main issue is the way it is injected: the style is set at the row level and not the cell level!

[sbidoul]

I'm setting this as draft, as I think a more profound refactoring is needed to do this correctly. See #647