Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] mis_builder: Add analytic_domain to report instance only if it is set #632

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

victoralmau
Copy link
Member

Changes done:

  • Add analytic_domain to report instance only if it is set
  • Remove old migration (8.0.2.0.0.0)
  • Add migration script to set the value of the analytic_domain field

Please @pedrobaeza and @pilarvargas-tecnativa can you review it?

@Tecnativa TT50696

@OCA-git-bot
Copy link
Contributor

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sbidoul
Copy link
Member

sbidoul commented Oct 1, 2024

/ocabot merge patch

Thanks for this. Do you plan to port it to 17?

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-632-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 990a9e0 into OCA:16.0 Oct 1, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6cf6a7a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants