Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] product_tax_multicompany_default: Extend ignored_company_ids context functionality #787

Draft
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

sergiobstoj
Copy link
Member

Give more functionality to ignored_company_ids context.

There could be cases where some companies could not apply to propagation, for example, if differs on country.

So here we add ignored_company_ids context into set_multicompany_taxes() in order to make the module inheritable to be able to exclude companies from tax propagation.

Taxes are already deleted before self.write, so replace [6, 0, [ids]] for [[4, id] for id in ids]

@OCA-git-bot
Copy link
Contributor

Hi @Shide,
some modules you are maintaining are being modified, check this out!

@sergiobstoj sergiobstoj force-pushed the 16.0-imp-product_tax_multicompany_default-ignored_company_ids branch 3 times, most recently from 2bb725f to d485989 Compare February 27, 2025 11:54
@aritzolea
Copy link

Looks good but I miss a test with ignored_company_ids context

@sergiobstoj sergiobstoj force-pushed the 16.0-imp-product_tax_multicompany_default-ignored_company_ids branch from d485989 to d04b566 Compare February 28, 2025 10:15
@sergiobstoj sergiobstoj force-pushed the 16.0-imp-product_tax_multicompany_default-ignored_company_ids branch from d04b566 to 2f6aaba Compare February 28, 2025 10:17
@aritzolea
Copy link

Looks good but I miss a test with ignored_company_ids context

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants