Support Python 2.7 #199
Support Python 2.7 #199
Conversation
SirTakobi
force-pushed
the
support-python-2.7
branch
4 times, most recently
from
3fa96df
to
9e8d501
Compare
|
The repos using the template should be fine with the first commit, but I'm struggling with fixing the CI of the template:
Any suggestion? |
SirTakobi
force-pushed
the
support-python-2.7
branch
3 times, most recently
from
847214f
to
f534ff3
Compare
SirTakobi
force-pushed
the
support-python-2.7
branch
from
f534ff3
to
48827ff
Compare
|
Shouldn't we consider dropping py2.7 support too instead? |
I think this deserves its own issue #200 |
| {%- endif %} | ||
| {%- if odoo_version < 11 %} | ||
| container: | ||
| image: python:2.7.18-buster |
There was a problem hiding this comment.
This may not be necessary since the ubunu-20.04 runner has python2 preinstalled.
| with: | ||
| python-version: "3.6" | ||
| {%- elif odoo_version < 14 %} | ||
| with: | ||
| python-version: "3.8" | ||
| {%- endif %} |
There was a problem hiding this comment.
We should pin the python version for all Odoo versions. But that's for another PR, I guess.
There was a problem hiding this comment.
It is, but the PR was closed.
|
@SirTakobi can you finish this one fixing the CI and attending comments? |
|
@SirTakobi 's new account is @SirAionTech |
|
We dropped python 2 support in #217 |
Originally posted by @StefanRijnhart in #198 (comment)
Fix the above issue, and the same issue also in Repositories using this template