Use ruff instead of black, isort, flake8, autoflake, pyupgrade #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
force-pushed
the
use-ruff
branch
2 times, most recently
from
2c13e05
to
fa48a1d
Compare
33 tasks
|
Here is an example of what this PR does: OCA/mis-builder#577 I would not enable this by default on existing branches but I think it's ok for 17.0. What do people think? |
|
OK, let's go with it by default in v17. |
yajo
requested changes
Oct 30, 2023
copier.yml
Outdated
| @@ -126,6 +126,18 @@ generate_requirements_txt: | |||
| Generate requirements.txt from addons manifests and optional overrides in setup.py | |||
| files. | |||
|
|
|||
| use_ruff: | |||
| default: no | |||
There was a problem hiding this comment.
Since this requires a manual template upgrade and ruff is a better default, I think we should enable it by default.
Suggested change
| default: no | |
| default: yes |
There was a problem hiding this comment.
Would that not enable ruff by default when we apply the template on existing repos?
|
I have handled the review comments and replied to some. @yajo can you update your review? |
celm1990
added a commit
to celm1990/doodba-copier-template
that referenced
this pull request
Nov 12, 2023
…ns-repo-template#219 - raise error because files are not exists
celm1990
added a commit
to celm1990/doodba-copier-template
that referenced
this pull request
Nov 12, 2023
…ns-repo-template#219 - raise error because files are not exists
celm1990
added a commit
to celm1990/doodba-copier-template
that referenced
this pull request
Nov 12, 2023
celm1990
added a commit
to celm1990/doodba-copier-template
that referenced
this pull request
Nov 13, 2023
…-addons-repo-template - because into oca-addons-repo-template now use ruff and this files are delete on commit, see PR OCA/oca-addons-repo-template#219 OCA/oca-addons-repo-template@299cb36
celm1990
added a commit
to celm1990/doodba-copier-template
that referenced
this pull request
Nov 13, 2023
…-addons-repo-template - because into oca-addons-repo-template now use ruff and this files are delete on commit, see PR OCA/oca-addons-repo-template#219 OCA/oca-addons-repo-template@299cb36
celm1990
added a commit
to celm1990/doodba-copier-template
that referenced
this pull request
Nov 13, 2023
…-addons-repo-template - because into oca-addons-repo-template now use ruff and this files are delete on commit, see PR OCA/oca-addons-repo-template#219 OCA/oca-addons-repo-template@299cb36
celm1990
added a commit
to celm1990/doodba-copier-template
that referenced
this pull request
Nov 19, 2023
…-addons-repo-template - because into oca-addons-repo-template now use ruff and this files are delete on commit, see PR OCA/oca-addons-repo-template#219 OCA/oca-addons-repo-template@299cb36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the docs: An extremely fast Python linter and code formatter, written in Rust..
The goal is multiple
I tried to configure rules that are compatible with the current flake8 and isort config.
To test this on a repo, run
pipx run copier copy git+https://github.com/acsone/oca-addons-repo-template --vcs-ref=use-ruff --trust .and answer
yesto the "use ruff" question.