-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(readme): poor man PSC indicator badge #261
base: master
Are you sure you want to change the base?
Conversation
Provide a more ergonomic way for OCA#140 (comment) to fix OCA#140.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, even if it's not ideal.
Two suggestions:
- Keep an issue open somewhere to tag this as in need of improvement.
- Consider using DuckDuckGo instead of Google :)
We should rather link to https://oca.github.io/repo-maintainer-conf/, because https://odoo-community.org/psc-teams is unmaintained. With some tweaks to https://github.com/OCA/repo-maintainer-conf/blob/master/.github/workflows/static.yml and the script it invokes, we should even be able to have a rich man solution. @simahawk @etobella are we ready to remove https://odoo-community.org/psc-teams or replace it with redirects to https://oca.github.io/repo-maintainer-conf ? |
|
Do you think it's worth waiting for this to happen? Or could we merge this workaround and just update the badge url once the rich man solution lands? |
Do you think it's worth waiting for this to happen? As it is changing the template of OCA modules, better to not push a temporary solution IMO that will be replaced by another in a few time. Matter of taste, though. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Provide a more ergonomic way for #140 (comment) to fix #140.