Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] product_custom_info #1091

Merged
merged 28 commits into from
Sep 22, 2023

Conversation

Rad0van
Copy link
Contributor

@Rad0van Rad0van commented Jun 16, 2022

Standard migration. Will temporarily fail till OCA/server-tools#2360 gets merged. So anyone interested please review that one as well. Thanx.

A question for those of greater skill than me: as it stands currently, this module provides a way to assign properties to product.template and product.product as well. But these are different by nature. Now I'm using [base|product]_custom_info to model various devices one of my customers sell - say for example washing machines. So there is a template for them. Some of them have no variants so all the property values are assigned to the product template. However there are some that have variants. In such case most of the values are the same and thus would be assigned to the product template however those specific should be assigned to product variants. But that's currently not possible. I could duplicate the washing machines product template to product variant template but then the properties will be different, etc.
Can anyone please suggest an elegant way to do this? @yajo @rvalyi @pedrobaeza @kittiu Thank you.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 18, 2022
@github-actions github-actions bot closed this Jan 22, 2023
@Rad0van
Copy link
Contributor Author

Rad0van commented Sep 9, 2023

Now that OCA/server-tools#2360 has been merged can someone please reopen this one? Thank you.

@bosd
Copy link
Contributor

bosd commented Sep 9, 2023

Now that OCA/server-tools#2360 has been merged can someone please reopen this one? Thank you.

Quick reply...
There is also this pr:
#1251

Didn't look into differences yet between these pr's.

But it might be quicker to open a new one.

@Rad0van
Copy link
Contributor Author

Rad0van commented Sep 9, 2023

Now that OCA/server-tools#2360 has been merged can someone please reopen this one? Thank you.

Quick reply... There is also this pr: #1251

Didn't look into differences yet between these pr's.

But it might be quicker to open a new one.

This one is 7 months older than the other which is also closed... Should a new one be created or this one re-opened? Maybe @yajo could provide an opinion here?

@etobella etobella reopened this Sep 22, 2023
@etobella
Copy link
Member

/ocabot rebase

yajo and others added 21 commits September 22, 2023 10:07
…oducts (OCA#168)

[ADD] product_custom_info: New module to have custom properties in products

===================
Product Custom Info
===================

This module extends products to allow having custom properties on them.

Installation
============

* You depend from module ``base_custom_info``, found in `OCA/server-tools
  <https://github.com/OCA/server-tools>`_.

Configuration
=============

To create custom info templates, please review documentation from
``base_custom_info`` module.

Usage
=====

To use this module, you need to:

* Go to *Sales > Products > Products*.
* Edit or create one.
* Create or choose a template in *Information > Custom Information Template*.
* Set values for the properties found in the new *Custom Info* tab.
Currently translated at 100.0% (9 of 9 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_custom_info
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_custom_info/pt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-12.0/product-attribute-12.0-product_custom_info
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_custom_info/
Currently translated at 100.0% (9 of 9 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_custom_info
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_custom_info/ca/
Fix website key in the manifests
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 15.0.

@OCA-git-bot OCA-git-bot force-pushed the 15.0-mig-product_custom_info branch from 610cf4b to 8f2d0f0 Compare September 22, 2023 10:07
@pedrobaeza pedrobaeza changed the title [15.0][MIG] product custom info [15.0][MIG] product_custom_info Sep 22, 2023
@pedrobaeza
Copy link
Member

/ocabot migration product_custom_info
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Sep 22, 2023
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1091-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

The migration issue (#919) has not been updated to reference the current pull request because a previous pull request (#1251) is not closed.
Perhaps you should check that there is no duplicate work.
CC @bizzappdev

@pedrobaeza
Copy link
Member

/ocabot migration product_custom_info

@OCA-git-bot OCA-git-bot mentioned this pull request Sep 22, 2023
65 tasks
@OCA-git-bot OCA-git-bot merged commit 01d7ac8 into OCA:15.0 Sep 22, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9914aef. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.