-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP][FIX]Product_profile: Support Create multi #1515
base: 16.0
Are you sure you want to change the base?
Conversation
Hi @sebastienbeau, @bealdav, @kevinkhao, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, good catch
Tests are still red. 😢 |
This is odd. On github website, there are 2 tests for Odoo and 2 test for OCB. On github mobile.. The failing tests are not there.. |
https://github.com/OCA/product-attribute/blob/16.0/.github/workflows/test.yml#L38-L50 Test are about include or exclude product_dimension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✨
Fixes the warning "The model odoo.addons.product_profile is not overriding the create method in batch" Fixup! Update product_profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Fixes the warning "The model odoo.addons.product_profile is not overriding the create method in batch"