Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP][FIX]Product_profile: Support Create multi #1515

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

bosd
Copy link
Contributor

@bosd bosd commented Feb 12, 2024

Fixes the warning "The model odoo.addons.product_profile is not overriding the create method in batch"

@OCA-git-bot
Copy link
Contributor

Hi @sebastienbeau, @bealdav, @kevinkhao,
some modules you are maintaining are being modified, check this out!

Copy link
Member

@bealdav bealdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, good catch

@bosd
Copy link
Contributor Author

bosd commented Feb 13, 2024

Tests are still red. 😢
Assume that the v16 branch here need some ❤️

@bosd
Copy link
Contributor Author

bosd commented Feb 13, 2024

This is odd. On github website, there are 2 tests for Odoo and 2 test for OCB.
One of them fails.

On github mobile.. The failing tests are not there..

@bealdav
Copy link
Member

bealdav commented Feb 13, 2024

https://github.com/OCA/product-attribute/blob/16.0/.github/workflows/test.yml#L38-L50

Test are about include or exclude product_dimension

@bosd bosd marked this pull request as ready for review February 13, 2024 18:44
Copy link

@Dranyel-Bosd Dranyel-Bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✨

@bosd bosd marked this pull request as draft July 17, 2024 12:05
@rousseldenis
Copy link
Sponsor Contributor

@bosd

Fixes the warning "The model odoo.addons.product_profile is not overriding the create method in batch"

Fixup! Update product_profile
@bosd bosd marked this pull request as ready for review September 30, 2024 09:56
Copy link

@Dranyel-Bosd Dranyel-Bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants