Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD][16.0] product_english_name module #1732

Open
wants to merge 3 commits into
base: 16.0
Choose a base branch
from

Conversation

bealdav
Copy link
Member

@bealdav bealdav commented Sep 30, 2024

Copy link

@PaulGoubert PaulGoubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionnal review OK

Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this attribution.
Some minor comments about warning and language.

Adittionally non blocking comment.
Compatability with product profile could be improved. As seen on runboat:
image

product_english_name/readme/CONFIGURE.rst Outdated Show resolved Hide resolved
product_english_name/readme/CONFIGURE.rst Outdated Show resolved Hide resolved
product_english_name/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
product_english_name/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
<field name="inherit_id" ref="product.product_template_form_view" />
<field name="arch" type="xml">
<xpath expr="//h1[1]" position="after">
<h5 groups="product_english_name.show_english_name">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


2024-09-30 14:58:43,884 478 WARNING odoo odoo.addons.base.models.ir_ui_view: The group 'product_english_name.show_english_name' defined in view does not exist!
View error context:
{'file': '/__w/product-attribute/product-attribute/product_english_name/views/product_template.xml',
 'line': 3,
 'name': 'product.template form',
 'view': ir.ui.view(1841,),
 'view.model': 'product.template',
 'view.parent': ir.ui.view(464,),
 'xmlid': 'product_template_form_view'} 

product_english_name/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
product_english_name/security/groups.xml Outdated Show resolved Hide resolved
product_english_name/__manifest__.py Outdated Show resolved Hide resolved
product_english_name/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
product_english_name/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
@bealdav
Copy link
Member Author

bealdav commented Oct 3, 2024

Thanks a lot, @bosd for your review

@bealdav
Copy link
Member Author

bealdav commented Oct 3, 2024

image

Finally works

Copy link
Contributor

@Kev-Roche Kev-Roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bealdav bealdav requested a review from bosd October 3, 2024 11:28
Copy link
Contributor

@mourad-ehm mourad-ehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants