-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD][16.0] product_english_name module #1732
base: 16.0
Are you sure you want to change the base?
Conversation
6c15e6a
to
35ce41f
Compare
35ce41f
to
c80b51d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionnal review OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<field name="inherit_id" ref="product.product_template_form_view" /> | ||
<field name="arch" type="xml"> | ||
<xpath expr="//h1[1]" position="after"> | ||
<h5 groups="product_english_name.show_english_name"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2024-09-30 14:58:43,884 478 WARNING odoo odoo.addons.base.models.ir_ui_view: The group 'product_english_name.show_english_name' defined in view does not exist!
View error context:
{'file': '/__w/product-attribute/product-attribute/product_english_name/views/product_template.xml',
'line': 3,
'name': 'product.template form',
'view': ir.ui.view(1841,),
'view.model': 'product.template',
'view.parent': ir.ui.view(464,),
'xmlid': 'product_template_form_view'}
Co-authored-by: bosd <[email protected]>
Thanks a lot, @bosd for your review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
cc @legalsylvain @HaraldPanten @rousseldenis @Kev-Roche