[18.0][MIG] product_status: Migration to 18.0 #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebalix
approved these changes
Dec 10, 2024
| @classmethod | ||
| def setUpClass(cls): | ||
| super().setUpClass() | ||
| cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True)) |
There was a problem hiding this comment.
Suggested change
| cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True)) |
As base class TestProductCommon now inherits from BaseCommon, you don't need to disable the tracking.
natuan9
force-pushed
the
18.0-mig-product_status
branch
from
9aa1449 to
9912949
Compare
sebalix
reviewed
Dec 24, 2024
| @@ -13,7 +13,7 @@ class TestProductStatusCase(TestProductCommon): | |||
| @classmethod | |||
| def setUpClass(cls): | |||
| super().setUpClass() | |||
| cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True)) | |||
| cls.env = cls.env(context=dict(cls.env.context)) | |||
There was a problem hiding this comment.
That means you can remove this whole line ;)
|
/ocabot migration product_status |
natuan9
force-pushed
the
18.0-mig-product_status
branch
2 times, most recently
from
bda785d to
8314dec
Compare
Before this change a product would never get back into its default state. Example: a new proudct with a new until date in the past will keep a state set as `new`. Instead it should be set to the default status.
natuan9
force-pushed
the
18.0-mig-product_status
branch
from
8314dec to
6eb32fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depend: