[18.0][MIG] product_sale_manufactured_for: Migration to 18.0 #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functionality that was before embedded into the module shopinvader_customer_special_product has been extracted into its own new module. Jira Card: BSCOS-2089
Before this change, customers that were archived couldn't be deleted from manufactured for partners.
Currently translated at 100.0% (5 of 5 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_sale_manufactured_for Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_sale_manufactured_for/it/
Currently translated at 100.0% (5 of 5 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_sale_manufactured_for Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_sale_manufactured_for/es/
|
/ocabot migration product_sale_manufactured_for |
rousseldenis
reviewed
Dec 5, 2024
| > | ||
| <!-- The domain is string, so we copy all of it, and add the new condition. --> | ||
| <attribute name="domain"> | ||
| [('sale_ok', '=', True), |
There was a problem hiding this comment.
IMHO, this is the weakness of the implementation as it could break inheritance
There was a problem hiding this comment.
Maybe a second field like 'product_manufactured_for_id` that will change product_id ?
There was a problem hiding this comment.
did you recommend some change improve this
There was a problem hiding this comment.
Nope, because there is no alternative for now.
But, careful, base domain has changed in v18. There is no more company criteria.
See https://github.com/odoo/odoo/blob/18.0/addons/sale/views/sale_order_views.xml#L419
There was a problem hiding this comment.
So now we still accept this implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends:
OCA/sale-workflow#3415