[18.0][MOV] product_packaging_type_required becomes product_packaging_level_required #1803

trisdoan · 2024-12-05T10:04:43Z

Note

depends on: [18.0][MIG] product_packaging_level: Migration to 18.0 #1806

This change

This module's feature was extracted from the original product_packaging_type_required module.
Now, packaging level is the one that should be marked as required

sebalix · 2024-12-11T11:22:59Z

product_packaging_type_required/models/product_packaging_type.py

+
+
+class PackageType(models.Model):
+    _inherit = "stock.package.type"


With this change:

I would rename the file stock_package_type.py

Should we also rename the module from product_packaging_type_required to stock_package_type_required, and move it in OCA/stock-logistics-warehouse alongside other stock_package_type_* modules (some in v16)?

cc @jbaudoux @rousseldenis

no, see my comment on the PR

sebalix · 2024-12-11T11:24:38Z

product_packaging_type_required/views/product_packaging_type_view.xml

@@ -1,29 +1,23 @@
 <?xml version="1.0" encoding="UTF-8" ?>


This file can be renamed stock_package_type.xml

jbaudoux

It's now package level. This is the one that needs to be marked as required.
Need to rename module to product_packaging_level_required and change models and filenames.

In v16, odoo integrated stock.package.storage.type as stock.package.type. And product.packaging.type has been renamed to stock.packaging.level.

…uired'

Currently translated at 100.0% (3 of 3 strings) Translation: product-attribute-13.0/product-attribute-13.0-product_packaging_type_required Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_packaging_type_required/es/

The limit was useless because never used. That's also the reason why the cron was working. Limit is dropped now and the code improved a little bit. A basic test and logging has been added too.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-14.0/product-attribute-14.0-product_packaging_type_required Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_packaging_type_required/

Currently translated at 100.0% (6 of 6 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_packaging_type_required Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_packaging_type_required/it/

Currently translated at 100.0% (6 of 6 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_packaging_type_required Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_packaging_type_required/es/

trisdoan · 2024-12-16T05:31:16Z

Hello @jbaudoux , @sebalix, I just updated the code, please help to take a look 🙏

jbaudoux

I'm not fan of the module name. What about product_packaging_auto_create?

jbaudoux · 2024-12-16T12:35:30Z

product_packaging_level_required/data/cron.xml

-            ref="product_packaging_type.model_product_packaging_type"
-            name="model_id"
-        />
+        <field ref="stock.model_stock_package_type" name="model_id" />


Should be level here also I guess

jbaudoux · 2024-12-16T12:38:41Z

product_packaging_level_required/models/product_packaging_level.py

-        )
-        required_packaging_types = self.search([("required", "=", True)])
+    def cron_check_create_required_packaging_level(self):
+        """Create required packaging level for each consumable product if missing."""


It's product packing you are creating

jbaudoux · 2024-12-16T12:51:26Z

product_packaging_level_required/models/product_packaging_level.py

-class ProductPackagingType(models.Model):
-    _inherit = "product.packaging.type"
+class ProductPackagingLevel(models.Model):
+    _inherit = "product.packaging.level"

    required = fields.Boolean()


auto_create_packaging
Help: a cron will create a packaging for each product missing a packaging with this level

…_required

trisdoan mentioned this pull request Dec 5, 2024

Migration to version 18.0 #1741

Open

25 tasks

sebalix reviewed Dec 11, 2024

View reviewed changes

jbaudoux suggested changes Dec 11, 2024

View reviewed changes

damdam-s and others added 23 commits December 16, 2024 11:01

[ADD] module 'product_packaging_type' and 'product_packaging_type_req…

0f12d1c

…uired'

Improvements according to review

ee0e7b8

Optimize creation of required packagings

11f57b4

Migrate product_packaging_type_required to 13.0

3c6cc87

run pre-commit with new prettiers

0d18b79

[UPD] Update product_packaging_type_required.pot

7ed34e4

[UPD] README.rst

681304d

[ADD] icon.png

35f33e4

Added translation using Weblate (Spanish)

f3c8b7f

[IMP] product_packaging_type_required: black, isort, prettier

810bae5

[MIG] product_packaging_type_required: Migration to 14.0

66b3085

[UPD] Update product_packaging_type_required.pot

5dfe390

[UPD] README.rst

8242bf3

product_packaging_type_required: add maintainers

b4aa11a

product_packaging_type_required: improve + add test

7044e60

The limit was useless because never used. That's also the reason why the cron was working. Limit is dropped now and the code improved a little bit. A basic test and logging has been added too.

[UPD] README.rst

8fc87d3

[UPD] README.rst

08f0f02

Added translation using Weblate (Italian)

5935efd

[IMP] product_packaging_type_required: pre-commit auto fixes

dca7c36

trisdoan marked this pull request as draft December 16, 2024 04:18

trisdoan force-pushed the 18.0-mig-product_packaging_type_required branch from 7b0f5f5 to d98a495 Compare December 16, 2024 05:05

trisdoan changed the title ~~[18.0][MIG] product_packaging_type_required: Migration to 18.0~~ [18.0][MOV] product_packaging_type_required: Migration to 18.0 Dec 16, 2024

trisdoan changed the title ~~[18.0][MOV] product_packaging_type_required: Migration to 18.0~~ [18.0][MOV] product_packaging_type_required becomes product_packaging_level_required Dec 16, 2024

trisdoan marked this pull request as ready for review December 16, 2024 05:14

trisdoan marked this pull request as draft December 16, 2024 05:14

trisdoan force-pushed the 18.0-mig-product_packaging_type_required branch from f477c29 to c6a6f1a Compare December 16, 2024 05:27

trisdoan marked this pull request as ready for review December 16, 2024 05:28

trisdoan requested review from sebalix and jbaudoux December 16, 2024 05:30

trisdoan force-pushed the 18.0-mig-product_packaging_type_required branch from c6a6f1a to afd1d9d Compare December 16, 2024 07:22

jbaudoux suggested changes Dec 16, 2024

View reviewed changes

trisdoan added 2 commits December 17, 2024 12:27

[MOV] product_packaging_type_required becomes product_packaging_level…

92cba80

…_required

[DON'T MERGE] test-requirements.txt

dc77e6a

trisdoan force-pushed the 18.0-mig-product_packaging_type_required branch from afd1d9d to dc77e6a Compare December 17, 2024 05:30

trisdoan requested a review from jbaudoux December 17, 2024 06:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MOV] product_packaging_type_required becomes product_packaging_level_required #1803

[18.0][MOV] product_packaging_type_required becomes product_packaging_level_required #1803

trisdoan commented Dec 5, 2024 •

edited

Loading

sebalix Dec 11, 2024

jbaudoux Dec 11, 2024

sebalix Dec 11, 2024

jbaudoux left a comment •

edited

Loading

trisdoan commented Dec 16, 2024

jbaudoux left a comment

jbaudoux Dec 16, 2024

jbaudoux Dec 16, 2024

jbaudoux Dec 16, 2024



		class PackageType(models.Model):
		_inherit = "stock.package.type"

[18.0][MOV] product_packaging_type_required becomes product_packaging_level_required #1803

Are you sure you want to change the base?

[18.0][MOV] product_packaging_type_required becomes product_packaging_level_required #1803

Conversation

trisdoan commented Dec 5, 2024 • edited Loading

Note

This change

sebalix Dec 11, 2024

Choose a reason for hiding this comment

jbaudoux Dec 11, 2024

Choose a reason for hiding this comment

sebalix Dec 11, 2024

Choose a reason for hiding this comment

jbaudoux left a comment • edited Loading

Choose a reason for hiding this comment

trisdoan commented Dec 16, 2024

jbaudoux left a comment

Choose a reason for hiding this comment

jbaudoux Dec 16, 2024

Choose a reason for hiding this comment

jbaudoux Dec 16, 2024

Choose a reason for hiding this comment

jbaudoux Dec 16, 2024

Choose a reason for hiding this comment

trisdoan commented Dec 5, 2024 •

edited

Loading

jbaudoux left a comment •

edited

Loading