[17.0][IMP] product_supplierinfo_for_customer: change _name_search product restrictions #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @luisg123v, |
ThiagoMForgeFlow
force-pushed
the
17.0-imp-product_supplierinfo_for_customer
branch
from
1b8d08f to
7ae43de
Compare
LoisRForgeFlow
approved these changes
Dec 18, 2024
JordiMForgeFlow
approved these changes
Dec 18, 2024
luisg123v
suggested changes
Dec 18, 2024
…restrictions Checking whether the search has a limit is restricting cases where it is important to retrieve the product by the customer's code. With this change, the restriction on res_ids_len being greater than the limit will only apply if the limit exists.
ThiagoMForgeFlow
force-pushed
the
17.0-imp-product_supplierinfo_for_customer
branch
from
7ae43de to
46de10d
Compare
Done, thanks. |
|
IMHO, the function should be documented to indicate what the override does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using these features with the product_supplierinfo_for_customer_sale module when searching for a product by code in an order line, the limit field has no value and does not work correctly.
@ForgeFlow