[MIG] product_pricelist_supplierinfo: Migration to 18.0 #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't depend on sales * Extended README * Tests focused on module specific features * Code optimization * Don't mix pricelist info with supplier info on criteria
Date order is passed by context, so we have to take this into account for computing properly available supplierinfo records.
If not, you can twist the order in the form and rules won't be applied according criteria
If you set the value "Based on" for using supplier info, but then you change the computation type to another one (like fixed price or discount), this code is still acting, so we should check both fields.
OCA#436) Previously, only worked fine with product.product.
Currently translated at 93.3% (14 of 15 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_pricelist_supplierinfo Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_pricelist_supplierinfo/es/
When having price per qty at the supplier level and if you want to base your pricelist on the supplier price, now you can define a margin on the product.supplierinfo
Use standard way to select the seller. As a result a bug in previous solution is fixed also: before this, all supplierinfo records having product_tmpl_id set, were considered as possible price for all product variants, even if product_id was set also. That resulted in same price for all variants even if supplierinfo records had different price for all variants.
If we have suppliers in two or more currencies, and we have a pricelist with an item that is selected the "Prices based on supplier info" option but the pricelist is in a currency different from the supplierinfo the compute of the price get the price on the same amount but with a different currency. With these changes, we are converting the price to the currency on the pricelist that is being used. Also, a test was added to prove the previous behaviour.
Currently translated at 100.0% (20 of 20 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_pricelist_supplierinfo Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_pricelist_supplierinfo/fr/
It is possible that this method is called on an inactive template, in which case product_variant_id returns empty recordset and _select_seller will raise expected singleton error.
If we have a product with a supplier with a UOM "A" but the product is sold with a UOM "B" the price we are getting is the same no matter the UOM. For example: Product with the price 1200 per Dozen and we sell a 1 unit we are getting the price of 1200 for that unit when we should be obtaining 100. With these changes, we are converting the price to the UOM that is being used on the sale or the default on the product. Also, a test was added to prove the previous behaviour.
[UPD] Update product_pricelist_supplierinfo.pot [UPD] README.rst
… when date is datetime. date may come from context
When we check the price of any product, the date that we pass on the context has to be a Datetime value or None. With this change we avoid to pass a False. Here you have the reference to the code that check that https://github.com/OCA/OCB/blob/13.0/addons/product/models/product.py#L599-L600 TT29935 product_pricelist_supplierinfo 13.0.1.0.2
TT31816 [UPD] Update product_pricelist_supplierinfo.pot [UPD] README.rst [IMP] update dotfiles [ci skip]
In the e-commerce, if we have a pricelist with a rule based on supplierinfo for a determined supplier partner, such partner could be not accesible for public users and the affected products could not be reached. TT31476
If we don't have a supplierinfo that below 1 unit we won't get any seller. We want to ensure that the condition is fully ignored to get whatever price given the other criterias. TT33659
…sers 0581b66 is not enough on v13 for avoiding the access error, so we sudoed the whole price fetch operation. TT36898
Currently translated at 100.0% (15 of 15 strings) Translation: product-attribute-17.0/product-attribute-17.0-product_pricelist_supplierinfo Translate-URL: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_pricelist_supplierinfo/it/
CLaurelB
force-pushed
the
18.0-mig-product_pricelist_supplierinfo-CLaurelB
branch
from
0f1a8e9 to
f35fd64
Compare
CLaurelB
force-pushed
the
18.0-mig-product_pricelist_supplierinfo-CLaurelB
branch
from
f35fd64 to
733ab9b
Compare
Changelog: - Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks. - Add a test for the scenario where the pricelist is not based on the supplier info, ensuring the price is calculated as expected natively. - Add a test for the scenario where there are no sellers linked to the product. - Replace the currency rate update method by the native `setup_other_currency` method, which requires inheriting from `BaseCommon`. Co-authored-by: mle <[email protected]>
CLaurelB
force-pushed
the
18.0-mig-product_pricelist_supplierinfo-CLaurelB
branch
from
733ab9b to
4174ebc
Compare
luisg123v
approved these changes
Jan 21, 2025
|
/ocabot migration product_pricelist_supplierinfo |
|
The migration issue (#1741) has not been updated to reference the current pull request because a previous pull request (#1745) is not closed. |
|
This PR has the |
|
Did you check #1745 ? |
Hello @moylop260, Yes, that's why @marielejeune is a co-author of the migration, and the PR description mentions it. I superseded the original PR because there was no recent activity. Regards. |
|
@JordiBForgeFlow @florian-dacosta Please, review It is already approved but you had comments in the original PR |
desdelinux
approved these changes
Jan 29, 2025
|
@JordiBForgeFlow @florian-dacosta @pedrobaeza this is ready, can you please merge it, please? |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Merging in order to avoid waiting for a long time again to be merged But if you have any comment we can discuss in a new issue |
|
Congratulations, your PR was merged at 33feecb. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersed #1745