-
-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0] [MIG] project_stage_extra_info: Migration to 18.0 #1382
Open
Borruso
wants to merge
7
commits into
OCA:18.0
Choose a base branch
from
Borruso:18.0-mig-project_stage_extra_info
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module adds a Description and Is closed stage field on Project stages.
Currently translated at 100.0% (6 of 6 strings) Translation: project-16.0/project-16.0-project_stage_extra_info Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_stage_extra_info/it/
Currently translated at 100.0% (6 of 6 strings) Translation: project-16.0/project-16.0-project_stage_extra_info Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_stage_extra_info/ca/
Borruso
force-pushed
the
18.0-mig-project_stage_extra_info
branch
2 times, most recently
from
November 27, 2024 10:15
b2962ae
to
1da9dfa
Compare
coleste
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
"The project stage 'To Do' should not be marked as closed.", | ||
) | ||
|
||
self.project.stage_id = self.stage_done.id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to do .id
, both are recordset objects
Borruso
force-pushed
the
18.0-mig-project_stage_extra_info
branch
from
December 17, 2024 09:03
1da9dfa
to
23fb695
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration from 16.0 to 18.0
Issue: #1347