Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][ADD] sale_project_reimbursement_cost: New module to display provisions and reimbur… #1388

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

carlos-lopez-tecnativa
Copy link
Contributor

…sement costs in the Project Updates dashboard

TT52049

@Tecnativa
@pedrobaeza could you please review this

@carlos-lopez-tecnativa carlos-lopez-tecnativa marked this pull request as draft December 5, 2024 15:53
@pedrobaeza pedrobaeza added this to the 17.0 milestone Dec 9, 2024
@pedrobaeza
Copy link
Member

On http://oca-project-17-0-pr1388-5e093d29ef25.runboat.odoo-community.org/web#id=24&cids=1&menu_id=260&action=424&model=sale.order&view_type=form, check that the line with the provision is not added to the corresponding section in the "To invoice".

@carlos-lopez-tecnativa
Copy link
Contributor Author

On http://oca-project-17-0-pr1388-5e093d29ef25.runboat.odoo-community.org/web#id=24&cids=1&menu_id=260&action=424&model=sale.order&view_type=form, check that the line with the provision is not added to the corresponding section in the "To invoice".

@pedrobaeza According to the requirements, the Provision lines are account.analytic.line records, not sale.order.line records. This sale order has not been invoiced yet.

@pedrobaeza
Copy link
Member

OK, understood. My bad. Then what you have to do is to not put such columns there. Only the column of "effective" amounts (the "Invoiced" one).

@carlos-lopez-tecnativa
Copy link
Contributor Author

OK, understood. My bad. Then what you have to do is to not put such columns there. Only the column of "effective" amounts (the "Invoiced" one).

The Provision section only displays the amount and the date. What is your expectation here?

image

@pedrobaeza
Copy link
Member

OK, it's correct. I saw the other 3 columns, but again I should see badly, as now I'm not able to reproduce it. I think it's because you have already changed some things in the runboat. But what about the reimbursable cost that is already invoiced and should be deducted from that section?

@carlos-lopez-tecnativa carlos-lopez-tecnativa force-pushed the 17.0-sale_project_reimbursement_cost branch from 5e093d2 to f5558c8 Compare December 9, 2024 17:57
@carlos-lopez-tecnativa
Copy link
Contributor Author

OK, it's correct. I saw the other 3 columns, but again I should see badly, as now I'm not able to reproduce it. I think it's because you have already changed some things in the runboat. But what about the reimbursable cost that is already invoiced and should be deducted from that section?

@pedrobaeza I updated the code to display only a table with provision lines and reimbursable lines. Additionally, I formatted the date. Please update your review.

@pedrobaeza
Copy link
Member

I get this error in runboat:

OwlError: Invalid props for component 'ProjectRightSidePanelSection': 'show' is not a boolean
    OwlError@http://oca-project-17-0-pr1388-f5558c8965fc.runboat.odoo-community.org/web/assets/9ad7330/web.assets_web.min.js:684:1
    validateProps@http://oca-project-17-0-pr1388-f5558c8965fc.runboat.odoo-community.org/web/assets/9ad7330/web.assets_web.min.js:1143:67
    template@http://oca-project-17-0-pr1388-f5558c8965fc.runboat.odoo-community.org/web/assets/9ad7330/web.assets_web.min.js line 1511 > Function:205:15
    _render@http://oca-project-17-0-pr1388-f5558c8965fc.runboat.odoo-community.org/web/assets/9ad7330/web.assets_web.min.js:940:96
    render@http://oca-project-17-0-pr1388-f5558c8965fc.runboat.odoo-community.org/web/assets/9ad7330/web.assets_web.min.js:939:6
    initiateRender@http://oca-project-17-0-pr1388-f5558c8965fc.runboat.odoo-community.org/web/assets/9ad7330/web.assets_web.min.js:1009:47

Also you can add product demo data for not having to set all the master data each time.

@carlos-lopez-tecnativa carlos-lopez-tecnativa force-pushed the 17.0-sale_project_reimbursement_cost branch 2 times, most recently from 2ec106e to 95be91f Compare December 10, 2024 11:23
@carlos-lopez-tecnativa carlos-lopez-tecnativa force-pushed the 17.0-sale_project_reimbursement_cost branch from 95be91f to 2e12640 Compare December 10, 2024 11:52
…sement costs in the Project Updates dashboard
@carlos-lopez-tecnativa carlos-lopez-tecnativa force-pushed the 17.0-sale_project_reimbursement_cost branch from 2e12640 to f4c46c1 Compare December 13, 2024 16:34
@carlos-lopez-tecnativa
Copy link
Contributor Author

@pedrobaeza According to the new flow, when validating the bill, if the provision has a remaining amount, a new line is added to the sale order with a negative quantity. Please update your review. Thanks in advance.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the new flow and working.

@pedrobaeza pedrobaeza marked this pull request as ready for review December 17, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants