[18.0][MIG] purchase_order_archive: Migration to 18.0 #2495
Conversation
Currently translated at 100.0% (3 of 3 strings) Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_archive Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_archive/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_order_archive Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_order_archive/
Currently translated at 100.0% (4 of 4 strings) Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_order_archive Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_order_archive/zh_CN/
…s + add active filter) TT44770
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_order_archive Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_order_archive/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_archive Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_archive/
Currently translated at 100.0% (4 of 4 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_archive Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_archive/it/
There was a problem hiding this comment.
Not your fault, but this module seems to have a pretty bad flaw: you can only archive a cancelled or locked order, but once archived you can set the cancelled order to draft and confirm it etc. etc.
Would you consider adding a constraint that prevents archived orders in any other states than cancel or done? If you do, a simple test would be good to have as well.
HeliconiaSolutions
force-pushed
the
18.0-mig-purchase_order_archive
branch
from
b1c5e1c to
b28324d
Compare
|
@StefanRijnhart , Thank you for pointing this out and for the valuable suggestion! I've implemented a constraint to prevent archived orders from being in states other than "cancel" or "done." I’ve also added a simple test case to validate this behavior. I’d greatly appreciate it if you could review the changes and let me know if there's anything else to improve. Thank you again for your input! |
|
This PR has the |
|
/ocabot migration purchase_order_archive |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 828dc4d. Thanks a lot for contributing to OCA. ❤️ |
No description provided.